Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasets for human mesh #159

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Add datasets for human mesh #159

merged 2 commits into from
Sep 30, 2020

Conversation

zengwang430521
Copy link
Collaborator

Rebase from new master branch.
Add the codes of datasets for human mesh estimation.
Add test codes and test data.

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #159 into master will decrease coverage by 0.34%.
The diff coverage is 73.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   82.53%   82.18%   -0.35%     
==========================================
  Files          91       97       +6     
  Lines        5358     5573     +215     
  Branches      911      929      +18     
==========================================
+ Hits         4422     4580     +158     
- Misses        772      823      +51     
- Partials      164      170       +6     
Flag Coverage Δ
#unittests 82.18% <73.48%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/datasets/mesh/mesh_h36m_dataset.py 24.07% <24.07%> (ø)
mmpose/datasets/datasets/mesh/mesh_base_dataset.py 82.92% <82.92%> (ø)
mmpose/datasets/datasets/mesh/mesh_adv_dataset.py 94.11% <94.11%> (ø)
mmpose/datasets/datasets/mesh/mesh_mix_dataset.py 95.45% <95.45%> (ø)
mmpose/datasets/datasets/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/mesh/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/mesh/mosh_dataset.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb200ba...5e2696b. Read the comment docs.

@jin-s13 jin-s13 requested a review from innerlee September 28, 2020 01:44
@innerlee
Copy link
Contributor

The merge path is a little bit complex, could you simplify it?

Currently:

  • human_mesh_dataset -> human_mesh
  • human_mesh_pipeline -> human_mesh_dataset

and human_mesh is not visible yet.

This will make things very hard to manage.

Pls try to pr against master. e.g. if human_mesh_pipeline is relatively independent, then it can be merged into master first.
Then human_mesh_dataset can be merged into master.
and then human_mesh, etc.

The other way, namely everything merges into human_mesh, and then merge everything to master, is hard to maintain.

@zengwang430521 zengwang430521 changed the base branch from human_mesh to master September 28, 2020 09:43
@innerlee
Copy link
Contributor

need to rebase master

@innerlee innerlee changed the title Rebase from new master branch. Add the codes of datasets for human mesh. Add datasets for human mesh Sep 29, 2020
@innerlee innerlee mentioned this pull request Sep 30, 2020
7 tasks
@innerlee innerlee merged commit 6604a31 into master Sep 30, 2020
@innerlee
Copy link
Contributor

need a following pr to update readme & changelog

@zengwang430521 zengwang430521 deleted the human_mesh_dataset branch September 30, 2020 20:06
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* Add datasets for human mesh estimation. Add test code and test data.

* fix a little bug in mesh_mix_dataset.py
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Add datasets for human mesh estimation. Add test code and test data.

* fix a little bug in mesh_mix_dataset.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants