-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Refine docs #1656
[Docs] Refine docs #1656
Conversation
Codecov ReportBase: 78.69% // Head: 77.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1656 +/- ##
===========================================
- Coverage 78.69% 77.78% -0.92%
===========================================
Files 203 204 +1
Lines 11575 11712 +137
Branches 2022 2050 +28
===========================================
+ Hits 9109 9110 +1
- Misses 2072 2206 +134
- Partials 394 396 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -17,7 +17,7 @@ | |||
dict( | |||
type='MultiStepLR', | |||
begin=0, | |||
end=210, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using the default value infinite
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think end=train_cfg['max_epochs']
is more intuitive for users to understand
docs/src/papers/algorithms/ipr.md
Outdated
@InProceedings{10.1007/978-3-030-01231-1_33, | ||
author={Sun, Xiao and Xiao, Bin and Wei, Fangyin and Liang, Shuang and Wei, Yichen}, | ||
title={Integral Human Pose Regression}, | ||
booktitle="Computer Vision -- ECCV 2018", | ||
year="2018", | ||
pages="536--553", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InProceedings{10.1007/978-3-030-01231-1_33, | |
author={Sun, Xiao and Xiao, Bin and Wei, Fangyin and Liang, Shuang and Wei, Yichen}, | |
title={Integral Human Pose Regression}, | |
booktitle="Computer Vision -- ECCV 2018", | |
year="2018", | |
pages="536--553", | |
@inproceedings{sun2018integral, | |
title={Integral human pose regression}, | |
author={Sun, Xiao and Xiao, Bin and Wei, Fangyin and Liang, Shuang and Wei, Yichen}, | |
booktitle={Proceedings of the European conference on computer vision (ECCV)}, | |
pages={529--545}, | |
year={2018} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And may also need to update the citation in the .md files under configs/
Motivation
Modification
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: