Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Refine installation and fix some docs #1659

Merged
merged 9 commits into from
Sep 19, 2022

Conversation

liqikai9
Copy link
Collaborator

@liqikai9 liqikai9 commented Sep 15, 2022

Motivation

Modification

Refine installation: add description about installing mmdet.

Fix some links in readme.

Fix demo result image due to previous bug.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-1.x@d26acda). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-1.x    #1659   +/-   ##
==========================================
  Coverage           ?   70.34%           
==========================================
  Files              ?      203           
  Lines              ?    11558           
  Branches           ?     2019           
==========================================
  Hits               ?     8130           
  Misses             ?     3086           
  Partials           ?      342           
Flag Coverage Δ
unittests 70.34% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@liqikai9 liqikai9 changed the title [Doc] Refine installation [Doc] Refine installation and fix links in readme Sep 15, 2022
@liqikai9 liqikai9 assigned ly015 and unassigned ly015 Sep 16, 2022
@liqikai9 liqikai9 changed the title [Doc] Refine installation and fix links in readme [Doc] Refine installation and fix some docs Sep 19, 2022
@ly015 ly015 merged commit 0b6c274 into open-mmlab:dev-1.x Sep 19, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
* [Doc] Refine installation docs

* modify installation verification

* fix links in readme

* fix typos in demo

* fix demo results

* fix demo image

* refine some docs

* update links

* fix overview image

Co-authored-by: lupeng <penglu2097@gmail.com>
ly015 pushed a commit that referenced this pull request Oct 14, 2022
* [Doc] Refine installation docs

* modify installation verification

* fix links in readme

* fix typos in demo

* fix demo results

* fix demo image

* refine some docs

* update links

* fix overview image

Co-authored-by: lupeng <penglu2097@gmail.com>
@liqikai9 liqikai9 deleted the refine-installation branch October 26, 2022 07:22
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* [Doc] Refine installation docs

* modify installation verification

* fix links in readme

* fix typos in demo

* fix demo results

* fix demo image

* refine some docs

* update links

* fix overview image

Co-authored-by: lupeng <penglu2097@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants