Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix udp regress #1682

Merged
merged 4 commits into from
Oct 9, 2022
Merged

[Fix] Fix udp regress #1682

merged 4 commits into from
Oct 9, 2022

Conversation

liqikai9
Copy link
Collaborator

Motivation

Fix loss in udp_regress.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 78.65% // Head: 78.65% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (fd78734) compared to base (d882fec).
Patch coverage: 85.71% of modified lines in pull request are covered.

❗ Current head fd78734 differs from pull request most recent head 9874d2b. Consider uploading reports for the commit 9874d2b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1682      +/-   ##
===========================================
- Coverage    78.65%   78.65%   -0.01%     
===========================================
  Files          203      203              
  Lines        11565    11568       +3     
  Branches      2019     2020       +1     
===========================================
+ Hits          9097     9099       +2     
  Misses        2080     2080              
- Partials       388      389       +1     
Flag Coverage Δ
unittests 78.65% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/codecs/utils/offset_heatmap.py 91.30% <ø> (ø)
mmpose/models/heads/heatmap_heads/heatmap_head.py 88.05% <80.00%> (-0.58%) ⬇️
mmpose/models/heads/heatmap_heads/vipnas_head.py 89.23% <100.00%> (+0.16%) ⬆️
mmpose/models/losses/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -83,7 +83,8 @@
in_channels=32,
out_channels=3 * 17,
deconv_out_channels=None,
loss=dict(type='KeypointMSELoss', use_target_weight=True),
loss=dict(type='CombinedTargetMSELoss', use_target_weight=True),
print_acc_pose=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print_acc_pose=False,
compute_acc=False,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to get it from train_cfg, like:

compute_acc = train_cfg.get('compute_acc', True)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think put it into train_cfg will be more reasonable.

@ly015 ly015 merged commit 8a5f725 into open-mmlab:dev-1.x Oct 9, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
@liqikai9 liqikai9 deleted the fix-udp-regress branch October 26, 2022 07:22
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants