Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] update CI maximum version of torch to 1.13 #1867

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Update CI maximum torch version from 1.12 to 1.13. The training/testing results of td-hm_hrnet-w32_8xb64-210e_coco-256x192.py with torch 1.13 match that in the logs.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis marked this pull request as ready for review December 8, 2022 02:10
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 79.77% // Head: 79.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (15781dc) compared to base (8e61de6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1867      +/-   ##
===========================================
- Coverage    79.77%   79.76%   -0.01%     
===========================================
  Files          209      209              
  Lines        12382    12382              
  Branches      2091     2091              
===========================================
- Hits          9878     9877       -1     
- Misses        2057     2058       +1     
  Partials       447      447              
Flag Coverage Δ
unittests 79.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/transforms/common_transforms.py 84.68% <0.00%> (-0.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis Ben-Louis requested a review from ly015 December 8, 2022 03:36
@ly015 ly015 merged commit 4582fc9 into open-mmlab:dev-1.x Dec 8, 2022
@Ben-Louis Ben-Louis deleted the update-pytorch-version branch December 8, 2022 06:27
ly015 pushed a commit to ly015/mmpose that referenced this pull request Feb 21, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants