Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interhand 2d dataset #202

Merged
merged 20 commits into from
Nov 3, 2020
Merged

add interhand 2d dataset #202

merged 20 commits into from
Nov 3, 2020

Conversation

liuxin9608
Copy link
Collaborator

No description provided.

@liuxin9608 liuxin9608 requested a review from innerlee October 20, 2020 10:35
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #202 into master will decrease coverage by 0.39%.
The diff coverage is 84.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   83.52%   83.13%   -0.40%     
==========================================
  Files         107      112       +5     
  Lines        6357     6446      +89     
  Branches     1024     1025       +1     
==========================================
+ Hits         5310     5359      +49     
- Misses        850      896      +46     
+ Partials      197      191       -6     
Flag Coverage Δ
unittests 83.13% <84.88%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/__init__.py 100.00% <ø> (ø)
mmpose/datasets/datasets/top_down/__init__.py 100.00% <ø> (ø)
...datasets/datasets/top_down/topdown_coco_dataset.py 88.44% <ø> (ø)
...datasets/datasets/top_down/topdown_mpii_dataset.py 42.71% <ø> (ø)
...sets/datasets/top_down/topdown_mpii_trb_dataset.py 51.75% <ø> (ø)
mmpose/models/detectors/mesh.py 92.24% <ø> (ø)
mmpose/models/losses/mesh_loss.py 97.65% <ø> (ø)
mmpose/utils/hooks.py 47.05% <47.05%> (ø)
mmpose/apis/inference.py 66.45% <58.82%> (-2.26%) ⬇️
mmpose/deprecated.py 65.38% <65.38%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef8e6d...5f80a9a. Read the comment docs.

@innerlee
Copy link
Contributor

When we change code in a breaking way, e.g., renaming a class, We need do some thing to help users with migration.

One way to do this is to leave an empty shadow class with the original name at the original path. In its init function, print a message about the rename, and then raise an error.

@jin-s13
Copy link
Collaborator

jin-s13 commented Oct 27, 2020

When we change code in a breaking way, e.g., renaming a class, We need do some thing to help users with migration.

One way to do this is to leave an empty shadow class with the original name at the original path. In its init function, print a message about the rename, and then raise an error.

Is it necessary to add this info now? Or is there any elegant way to do so?

@jin-s13
Copy link
Collaborator

jin-s13 commented Oct 27, 2020

There are conflicts @liuxin9608 , please resolve them.

@innerlee
Copy link
Contributor

Looks good modulus the above comments.

one comment for future reference:
when there is an unrelated bulk change like the keys=['img'], formatting, the best way is to make a separate pr for that change.
this will make reviews much easier, and that pr will also be merged quicker

@innerlee innerlee merged commit bb029d1 into master Nov 3, 2020
@innerlee innerlee deleted the interhand2d branch November 4, 2020 06:06
wusize pushed a commit that referenced this pull request Nov 13, 2020
* add interhand 2d dataset

* fix image path

* add hand base dataset

* change pck interface

* fix pck

* fix forward

* change hand configs

* fix inference

* fix bbox

* resolve comments

* rebase

* resolve comments

* resolve comments

* fix lint

* update model and test results

* update models

* deprecated

* fix docs

* fix relative path

* add data preparation
wusize pushed a commit that referenced this pull request Nov 13, 2020
* add interhand 2d dataset

* fix image path

* add hand base dataset

* change pck interface

* fix pck

* fix forward

* change hand configs

* fix inference

* fix bbox

* resolve comments

* rebase

* resolve comments

* resolve comments

* fix lint

* update model and test results

* update models

* deprecated

* fix docs

* fix relative path

* add data preparation
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add interhand 2d dataset

* fix image path

* add hand base dataset

* change pck interface

* fix pck

* fix forward

* change hand configs

* fix inference

* fix bbox

* resolve comments

* rebase

* resolve comments

* resolve comments

* fix lint

* update model and test results

* update models

* deprecated

* fix docs

* fix relative path

* add data preparation
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* fix config

* add docstring and unit test

* update tutorial

* update tutorial

* fix markdown format

* fix markdown format
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add interhand 2d dataset

* fix image path

* add hand base dataset

* change pck interface

* fix pck

* fix forward

* change hand configs

* fix inference

* fix bbox

* resolve comments

* rebase

* resolve comments

* resolve comments

* fix lint

* update model and test results

* update models

* deprecated

* fix docs

* fix relative path

* add data preparation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants