Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openpose keypoints visualization #2055

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Ruid6
Copy link
Contributor

@Ruid6 Ruid6 commented Mar 14, 2023

Motivation

Visualize rtmpose detection results in the openpose format.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

Sorry, something went wrong.

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023

CLA assistant check
All committers have signed the CLA.

@ly015 ly015 requested a review from Tau-J March 14, 2023 08:23
@ly015
Copy link
Member

ly015 commented Mar 14, 2023

Thank you very much for contributing to MMPose! We will review this PR asap. Meanwhile, there seem to be lint issues in the PR code. Could you please follow the steps in the Contribution Guide to install the pre-commit hook and run pre-commit run --all-files? It will check and automatically fix the code style issue.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (936fed3) 81.79% compared to head (57da8a5) 81.80%.

❗ Current head 57da8a5 differs from pull request most recent head f214360. Consider uploading reports for the commit f214360 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2055   +/-   ##
========================================
  Coverage    81.79%   81.80%           
========================================
  Files          227      227           
  Lines        13440    13440           
  Branches      2285     2285           
========================================
+ Hits         10993    10994    +1     
+ Misses        1935     1930    -5     
- Partials       512      516    +4     
Flag Coverage Δ
unittests 81.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 merged commit 0c6a007 into open-mmlab:dev-1.x Mar 14, 2023
@Ruid6 Ruid6 deleted the Ruid/Add_tool_mmpose_to_openpose branch March 14, 2023 12:41
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants