Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix naming issue #2285

Merged
merged 1 commit into from
Apr 23, 2023
Merged

fix naming issue #2285

merged 1 commit into from
Apr 23, 2023

Conversation

xin-li-67
Copy link
Contributor

Motivation

fix naming error of the model config file 8x64e -> 8xb64

Modification

configs/face_2d_keypoint/topdown_regression/wflw/td-reg_res50_8xb64-210e_wflw-256x256.py
configs/face_2d_keypoint/topdown_regression/wflw/resnet_wflw.md
configs/face_2d_keypoint/topdown_regression/wflw/resnet_wflw.yml
configs/face_2d_keypoint/topdown_regression/wflw/README.md

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (896e9d5) 82.25% compared to head (260d05c) 82.31%.

❗ Current head 260d05c differs from pull request most recent head c23b7ca. Consider uploading reports for the commit c23b7ca to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2285      +/-   ##
===========================================
+ Coverage    82.25%   82.31%   +0.06%     
===========================================
  Files          228      230       +2     
  Lines        13387    13552     +165     
  Branches      2268     2301      +33     
===========================================
+ Hits         11011    11155     +144     
- Misses        1862     1866       +4     
- Partials       514      531      +17     
Flag Coverage Δ
unittests 82.31% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 46a4169 into open-mmlab:dev-1.x Apr 23, 2023
@xin-li-67 xin-li-67 deleted the naming_err branch April 23, 2023 02:46
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants