-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support SKPS model #2366
Conversation
Hi @610265158 , can you share the ckpts and training log with me? You can upload it to an online driver. I'll help to upload it to mmpose server. |
I will rerun the code and test the reproducibility , and share them later. |
btw, is there any paper or technical report about this model? We're glad to add citation in docs. |
Hi, the pretrained weight and log is uploaded as in readme. There is no paper or tech report about the model. However the model is a combine with some techs. The key idea is the head and loss, but not innovative enough. Refer to my git repo if it could. And there is some postprocess methods that may help in keypoint tasks. |
Of course it helps. We'll appreciate a lot if you can add them to MMPose. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2366 +/- ##
===========================================
- Coverage 81.99% 79.26% -2.74%
===========================================
Files 232 248 +16
Lines 13638 14859 +1221
Branches 2319 2577 +258
===========================================
+ Hits 11183 11778 +595
- Misses 1919 2501 +582
- Partials 536 580 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hi @610265158 , could you please fix the lint according to the details? |
Yes, i will check it soon. |
|
||
return encoded | ||
|
||
def generate_offside_heatmap( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 'offside', do you mean 'offset'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'generate_offset_map' seems better. Because it is not actually heatmaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's better, I will check them.
And another question. For gt labels returned, which key is better for this offset_map. I place it with displacements now, is it ok?
projects/skps/configs/td-hm_hrnetv2-w18_skps-1xb16-160e_cofw-256x256.py
Outdated
Show resolved
Hide resolved
delete this file , no use
Motivation
A simple face keypoints model, achieves 0.394 nme with wflw, which is a SOTA result, and that may help with us.
Modification
Including a head and a codec. Codes placed in project.skps folder.
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: