SImplified chained-comparison. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 83.03% 83.09% +0.05%
==========================================
Files 112 112
Lines 6448 6441 -7
Branches 1029 1029
==========================================
- Hits 5354 5352 -2
+ Misses 901 896 -5
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
Nov 10, 2020
| if (pt[2] > 0 and x >= 0 and y >= 0 and x < self.output_res | ||
| and y < self.output_res): | ||
| if (pt[2] > 0 and self.output_res > y >= 0 | ||
| and self.output_res > x >= 0): |
There was a problem hiding this comment.
< is more natural, 0 <= x < self.output_res
yaochaorui
force-pushed
the
ycr/R1716
branch
from
0933706
to
7b39dd5
Compare
innerlee
approved these changes
Nov 10, 2020
innerlee
approved these changes
Nov 11, 2020
wusize
pushed a commit
that referenced
this pull request
Nov 13, 2020
* SImplified chained-comparison. * Modified following mentor's convention. * Pre-commit.
wusize
pushed a commit
that referenced
this pull request
Nov 13, 2020
* SImplified chained-comparison. * Modified following mentor's convention. * Pre-commit.
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
* SImplified chained-comparison. * Modified following mentor's convention. * Pre-commit.
HAOCHENYE
added a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
* Support multiple optimizers * minor refinement * improve unit tests * minor fix * Update unit tests for resuming or saving ckpt for multiple optimizers * refine docstring * refine docstring * fix typo * update docstring * refactor the logic to build multiple optimizers * resolve comments * ParamSchedulers spports multiple optimizers * add optimizer_wrapper * fix comment and docstirng * fix unit test * add unit test * refine docstring * RuntimeInfoHook supports printing multi learning rates * resolve comments * add optimizer_wrapper * fix mypy * fix lint * fix OptimizerWrapperDict docstring and add unit test * rename OptimizerWrapper to OptimWrapper, OptimWrapperDict inherit OptimWrapper, and fix as comment * Fix AmpOptimizerWrapper * rename build_optmizer_wrapper to build_optim_wrapper * refine optimizer wrapper * fix AmpOptimWrapper.step, docstring * resolve confict * rename DefaultOptimConstructor * fix as comment * rename clig grad auguments * refactor optim_wrapper config * fix docstring of DefaultOptimWrapperConstructor fix docstring of DefaultOptimWrapperConstructor * add get_lr method to OptimWrapper and OptimWrapperDict * skip some amp unit test * fix unit test * fix get_lr, get_momentum docstring * refactor get_lr, get_momentum, fix as comment * fix error message Co-authored-by: zhouzaida <zhouzaida@163.com>
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* SImplified chained-comparison. * Modified following mentor's convention. * Pre-commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #245