Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified if-expression. #267

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Simplified if-expression. #267

merged 2 commits into from
Nov 11, 2020

Conversation

yaochaorui
Copy link
Contributor

@yaochaorui yaochaorui commented Nov 10, 2020

Fix #247

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #267 (52efe67) into master (28256fe) will increase coverage by 0.05%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   83.03%   83.09%   +0.05%     
==========================================
  Files         112      112              
  Lines        6448     6441       -7     
  Branches     1029     1029              
==========================================
- Hits         5354     5352       -2     
+ Misses        901      896       -5     
  Partials      193      193              
Flag Coverage Δ
unittests 83.06% <56.25%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/test.py 27.90% <0.00%> (ø)
mmpose/core/evaluation/eval_hooks.py 66.66% <0.00%> (ø)
...asets/datasets/bottom_up/bottom_up_base_dataset.py 82.50% <0.00%> (ø)
mmpose/models/backbones/base_backbone.py 100.00% <ø> (+6.66%) ⬆️
mmpose/models/backbones/cpm.py 90.19% <ø> (-0.19%) ⬇️
mmpose/models/backbones/hourglass.py 92.85% <ø> (-0.11%) ⬇️
mmpose/models/detectors/base.py 60.41% <ø> (+4.64%) ⬆️
mmpose/models/losses/mesh_loss.py 97.65% <0.00%> (ø)
mmpose/models/losses/multi_loss_factory.py 100.00% <ø> (ø)
mmpose/apis/inference.py 65.83% <75.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28256fe...b228618. Read the comment docs.

@@ -235,7 +235,7 @@ def __init__(self,

self.layers = nn.ModuleList()
for i, num_blocks in enumerate(self.stage_blocks):
first_block = True if i == 0 else False
first_block = bool(i == 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool can be omitted

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified.

@innerlee innerlee merged commit 9dcec05 into master Nov 11, 2020
@innerlee innerlee deleted the ycr/R1719 branch November 12, 2020 12:31
wusize pushed a commit that referenced this pull request Nov 13, 2020
* Simplified if-expression.

* Simplified following mentor's convention.
wusize pushed a commit that referenced this pull request Nov 13, 2020
* Simplified if-expression.

* Simplified following mentor's convention.
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* Simplified if-expression.

* Simplified following mentor's convention.
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* impl lr and momentum visualizer

* provide fakerun
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Simplified if-expression.

* Simplified following mentor's convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint: R1719
2 participants