Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-self-use #275

Merged
merged 1 commit into from
Nov 12, 2020
Merged

no-self-use #275

merged 1 commit into from
Nov 12, 2020

Conversation

yaochaorui
Copy link
Contributor

Fix #242

@@ -229,7 +229,8 @@ def __init__(self, rot_factor, scale_factor, scale_type, trans_factor):
self.scale_type = scale_type
self.trans_factor = trans_factor

def _get_affine_matrix(self, center, scale, res, rot=0):
@classmethod
Copy link
Contributor

@innerlee innerlee Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@classmethod or @staticmethod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me check. Thanks

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #275 (644285c) into master (f44898b) will increase coverage by 0.56%.
The diff coverage is 88.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   83.09%   83.65%   +0.56%     
==========================================
  Files         112      113       +1     
  Lines        6441     6823     +382     
  Branches     1029     1083      +54     
==========================================
+ Hits         5352     5708     +356     
- Misses        896      918      +22     
- Partials      193      197       +4     
Flag Coverage Δ
unittests 83.65% <88.98%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/test.py 27.58% <0.00%> (-0.33%) ⬇️
mmpose/core/evaluation/eval_hooks.py 66.66% <0.00%> (ø)
...asets/datasets/bottom_up/bottom_up_base_dataset.py 82.50% <0.00%> (ø)
mmpose/datasets/datasets/mesh/mesh_mix_dataset.py 91.30% <0.00%> (-4.16%) ⬇️
mmpose/models/losses/mesh_loss.py 97.67% <66.66%> (+0.01%) ⬆️
...models/keypoint_heads/top_down_multi_stage_head.py 85.06% <69.33%> (-14.94%) ⬇️
mmpose/datasets/pipelines/bottom_up_transform.py 90.04% <80.00%> (+0.08%) ⬆️
mmpose/datasets/pipelines/top_down_transform.py 83.49% <85.29%> (+2.88%) ⬆️
mmpose/models/backbones/rsn.py 99.14% <99.14%> (ø)
mmpose/core/fp16/hooks.py 27.27% <100.00%> (+2.27%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44898b...39e8a07. Read the comment docs.

@innerlee innerlee merged commit eda39c7 into master Nov 12, 2020
@innerlee innerlee deleted the ycr/R0201 branch November 12, 2020 12:31
wusize pushed a commit that referenced this pull request Nov 13, 2020
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
…#275)

* [Feature] Support overwrite default scope with "_scope_".

* add ut

* add ut
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint: R0201
2 participants