-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-self-use #275
no-self-use #275
Conversation
7d4885f
to
53dc52b
Compare
@@ -229,7 +229,8 @@ def __init__(self, rot_factor, scale_factor, scale_type, trans_factor): | |||
self.scale_type = scale_type | |||
self.trans_factor = trans_factor | |||
|
|||
def _get_affine_matrix(self, center, scale, res, rot=0): | |||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@classmethod
or @staticmethod
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops let me check. Thanks
53dc52b
to
39e8a07
Compare
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 83.09% 83.65% +0.56%
==========================================
Files 112 113 +1
Lines 6441 6823 +382
Branches 1029 1083 +54
==========================================
+ Hits 5352 5708 +356
- Misses 896 918 +22
- Partials 193 197 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…#275) * [Feature] Support overwrite default scope with "_scope_". * add ut * add ut
Fix #242