Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpate reqs with missing deps #285

Merged
merged 3 commits into from
Nov 26, 2020
Merged

udpate reqs with missing deps #285

merged 3 commits into from
Nov 26, 2020

Conversation

SMHendryx
Copy link
Contributor

had to add some deps to the requirements to get a working installation. See #282

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #285 (ba74f4d) into master (586cea7) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   83.85%   83.82%   -0.03%     
==========================================
  Files         114      114              
  Lines        7072     7085      +13     
  Branches     1118     1122       +4     
==========================================
+ Hits         5930     5939       +9     
  Misses        941      941              
- Partials      201      205       +4     
Flag Coverage Δ
unittests 83.82% <87.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sets/datasets/top_down/topdown_mpii_trb_dataset.py 52.17% <ø> (ø)
mmpose/models/detectors/base.py 58.69% <ø> (-1.73%) ⬇️
mmpose/models/detectors/bottom_up.py 63.70% <66.66%> (-0.36%) ⬇️
mmpose/models/detectors/top_down.py 79.16% <80.00%> (+0.02%) ⬆️
mmpose/datasets/pipelines/bottom_up_transform.py 90.04% <100.00%> (ø)
mmpose/datasets/pipelines/mesh_transform.py 95.45% <100.00%> (ø)
mmpose/datasets/pipelines/shared_transform.py 96.77% <100.00%> (ø)
mmpose/datasets/pipelines/top_down_transform.py 83.49% <100.00%> (ø)
mmpose/models/detectors/mesh.py 92.43% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586cea7...a590b1b. Read the comment docs.

@innerlee
Copy link
Contributor

  • cython is used by dependencies, and it is not a runtime requirement
  • technically speaking, mmcv-full is an dependency of mmdet, not mmpose. It is needed only for this demo, where mmdet is used to provide bboxes.
  • torch is needed also, i guess.

Solution:

  • Cython
  • mmcv>=1.1.1, mmcv-full
  • add torch alongside torchvision

@SMHendryx
Copy link
Contributor Author

ok, updated following your suggestion @innerlee

@innerlee
Copy link
Contributor

image

@innerlee
Copy link
Contributor

innerlee commented Nov 22, 2020

According to the error message, torch has to be removed here :/ my bad

@innerlee innerlee merged commit db6ea90 into open-mmlab:master Nov 26, 2020
@OpenMMLab-Assistant-007
Copy link

Hi!
@SMHendryx
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* udpate reqs with missing deps

* add torch, remove mmcv-full and Cython from from reqs

* Update runtime.txt

Co-authored-by: lizz <innerlee@users.noreply.github.com>
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* fix BaseDataPreprocessor

* fix BaseDataPreprocessor

* change device type to torch.device

* change device type to torch.device

* fix cpu method of base model
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* udpate reqs with missing deps

* add torch, remove mmcv-full and Cython from from reqs

* Update runtime.txt

Co-authored-by: lizz <innerlee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants