Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new post-process #288

Merged
merged 10 commits into from
Nov 30, 2020
Merged

add new post-process #288

merged 10 commits into from
Nov 30, 2020

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Nov 20, 2020

Migration guide:

From

        post_process=True,
        unbiased_decoding=False,

to

        post_process='default',

, and from

        post_process=True,
        unbiased_decoding=True,

to

        post_process='unbiased',

, and from

        post_process=False,

to

        post_process=None,

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #288 (f55502c) into master (586cea7) will decrease coverage by 0.01%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   83.85%   83.83%   -0.02%     
==========================================
  Files         114      115       +1     
  Lines        7072     7251     +179     
  Branches     1118     1151      +33     
==========================================
+ Hits         5930     6079     +149     
- Misses        941      955      +14     
- Partials      201      217      +16     
Flag Coverage Δ
unittests 83.83% <85.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/__init__.py 100.00% <ø> (ø)
mmpose/datasets/datasets/__init__.py 100.00% <ø> (ø)
...datasets/datasets/top_down/topdown_coco_dataset.py 88.50% <ø> (ø)
...sets/datasets/top_down/topdown_mpii_trb_dataset.py 52.17% <ø> (ø)
mmpose/models/detectors/base.py 58.69% <ø> (-1.73%) ⬇️
mmpose/core/evaluation/top_down_eval.py 84.44% <57.89%> (-10.30%) ⬇️
mmpose/models/detectors/bottom_up.py 63.70% <66.66%> (-0.36%) ⬇️
mmpose/models/detectors/top_down.py 79.76% <80.00%> (+0.62%) ⬆️
...atasets/datasets/top_down/topdown_jhmdb_dataset.py 91.66% <91.66%> (ø)
mmpose/__init__.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586cea7...f3231ff. Read the comment docs.

@wusize wusize requested a review from innerlee November 20, 2020 14:03
@wusize
Copy link
Collaborator Author

wusize commented Nov 20, 2020

Add post-process for mspn and rsn.

@wusize wusize requested a review from jin-s13 November 22, 2020 07:46
@wusize
Copy link
Collaborator Author

wusize commented Nov 23, 2020

All checks have passed.

@@ -59,9 +59,9 @@
test_cfg=dict(
flip_test=True,
post_process=True,
shift_heatmap=True,
shift_heatmap=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change affect accuracies (if any) reported in model zoo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the config for RSN. And other models are not changed. So it will not affect the model zoo.

@jin-s13
Copy link
Collaborator

jin-s13 commented Nov 27, 2020

Some minor comments.

wusize and others added 2 commits November 27, 2020 16:25
Signed-off-by: lizz <lizz@sensetime.com>
post_process (str/None): Choice of methods to post-process
heatmaps. Currently supported: None, 'default', 'unbiased',
'megvii'.
unbiased (bool): Option to use unbiased decoding. Mutually
Copy link
Contributor

@innerlee innerlee Nov 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, so unbiased is new in this pr?
If so, we do not need to deprecate it.

edit: no

Signed-off-by: lizz <lizz@sensetime.com>
Signed-off-by: lizz <lizz@sensetime.com>
Signed-off-by: lizz <lizz@sensetime.com>
@innerlee
Copy link
Contributor

The name default does not feels perfect. Any suggestions? @jin-s13 @wusize @Canwang-sjtu

@innerlee innerlee merged commit 2360640 into master Nov 30, 2020
@jin-s13 jin-s13 deleted the new_post_process branch November 30, 2020 05:05
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
* add x3d model

* minor fix

* update

* update

* fix x3d code

* update x3d_head

* fix bug

* se then swish

* add random rescale augmentation

* resolve comments

* update changelog

* add X3d README and configs

* resolve comments

* add links to ckpts

* update changelog

* add unit-test

* resolve comments & fix unittest

* add unittest for randomrescale

* fix the order of checks in RandomRescale

* fix testing

* fix testing

* revise the code of RandomRescale

* resolve comments

* fix lint
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add new post-process

* add new post-process

* add deprecation warnings

* fix the bugs

* changes in topdown.py

* fix some bugs

* simplify code

Signed-off-by: lizz <lizz@sensetime.com>

* change configs accordingly

Signed-off-by: lizz <lizz@sensetime.com>

* One more

Signed-off-by: lizz <lizz@sensetime.com>

* Simplify

Signed-off-by: lizz <lizz@sensetime.com>

Co-authored-by: lizz <lizz@sensetime.com>
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* support mlu

* add ut and refine docstring
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add new post-process

* add new post-process

* add deprecation warnings

* fix the bugs

* changes in topdown.py

* fix some bugs

* simplify code

Signed-off-by: lizz <lizz@sensetime.com>

* change configs accordingly

Signed-off-by: lizz <lizz@sensetime.com>

* One more

Signed-off-by: lizz <lizz@sensetime.com>

* Simplify

Signed-off-by: lizz <lizz@sensetime.com>

Co-authored-by: lizz <lizz@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants