-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new post-process #288
add new post-process #288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 83.85% 83.83% -0.02%
==========================================
Files 114 115 +1
Lines 7072 7251 +179
Branches 1118 1151 +33
==========================================
+ Hits 5930 6079 +149
- Misses 941 955 +14
- Partials 201 217 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Add post-process for mspn and rsn. |
All checks have passed. |
@@ -59,9 +59,9 @@ | |||
test_cfg=dict( | |||
flip_test=True, | |||
post_process=True, | |||
shift_heatmap=True, | |||
shift_heatmap=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change affect accuracies (if any) reported in model zoo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the config for RSN. And other models are not changed. So it will not affect the model zoo.
Some minor comments. |
Signed-off-by: lizz <lizz@sensetime.com>
post_process (str/None): Choice of methods to post-process | ||
heatmaps. Currently supported: None, 'default', 'unbiased', | ||
'megvii'. | ||
unbiased (bool): Option to use unbiased decoding. Mutually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, so unbiased
is new in this pr?
If so, we do not need to deprecate it.
edit: no
The name |
* add x3d model * minor fix * update * update * fix x3d code * update x3d_head * fix bug * se then swish * add random rescale augmentation * resolve comments * update changelog * add X3d README and configs * resolve comments * add links to ckpts * update changelog * add unit-test * resolve comments & fix unittest * add unittest for randomrescale * fix the order of checks in RandomRescale * fix testing * fix testing * revise the code of RandomRescale * resolve comments * fix lint
* add new post-process * add new post-process * add deprecation warnings * fix the bugs * changes in topdown.py * fix some bugs * simplify code Signed-off-by: lizz <lizz@sensetime.com> * change configs accordingly Signed-off-by: lizz <lizz@sensetime.com> * One more Signed-off-by: lizz <lizz@sensetime.com> * Simplify Signed-off-by: lizz <lizz@sensetime.com> Co-authored-by: lizz <lizz@sensetime.com>
* support mlu * add ut and refine docstring
* add new post-process * add new post-process * add deprecation warnings * fix the bugs * changes in topdown.py * fix some bugs * simplify code Signed-off-by: lizz <lizz@sensetime.com> * change configs accordingly Signed-off-by: lizz <lizz@sensetime.com> * One more Signed-off-by: lizz <lizz@sensetime.com> * Simplify Signed-off-by: lizz <lizz@sensetime.com> Co-authored-by: lizz <lizz@sensetime.com>
Migration guide:
From
to
post_process='default',
, and from
to
post_process='unbiased',
, and from
post_process=False,
to
post_process=None,