Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint remove object from bases #294

Merged
merged 2 commits into from
Nov 23, 2020
Merged

pylint remove object from bases #294

merged 2 commits into from
Nov 23, 2020

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Nov 22, 2020

fix #250

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #294 (344bd10) into master (586cea7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   83.85%   83.84%   -0.01%     
==========================================
  Files         114      114              
  Lines        7072     7070       -2     
  Branches     1118     1118              
==========================================
- Hits         5930     5928       -2     
  Misses        941      941              
  Partials      201      201              
Flag Coverage Δ
unittests 83.81% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sets/datasets/top_down/topdown_mpii_trb_dataset.py 52.17% <ø> (ø)
mmpose/models/detectors/base.py 58.69% <ø> (-1.73%) ⬇️
mmpose/datasets/pipelines/bottom_up_transform.py 90.04% <100.00%> (ø)
mmpose/datasets/pipelines/mesh_transform.py 95.45% <100.00%> (ø)
mmpose/datasets/pipelines/shared_transform.py 96.77% <100.00%> (ø)
mmpose/datasets/pipelines/top_down_transform.py 83.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586cea7...8b24ecf. Read the comment docs.

@@ -167,7 +167,7 @@ def _flip_joints_3d(joints_3d, joints_3d_visible, flip_pairs):


@PIPELINES.register_module()
class LoadIUVFromFile(object):
class LoadIUVFromFile():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the () could be removed also

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@innerlee innerlee merged commit 6268fcd into master Nov 23, 2020
@jin-s13 jin-s13 deleted the R0205 branch November 23, 2020 08:47
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
* resolve comments

* update changelog

* add omnisource

* resolve comments

* replace tab with space

* final fix

* Update preparing_omnisource.md
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* pylint remove object from bases

* remove redundant parentheses
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* support resume from ceph

* move func and refine

* delete symlink

* fix unittest

* perserve _allow_symlink and symlink
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* pylint remove object from bases

* remove redundant parentheses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint: R0205
2 participants