add use_nms option #318
add use_nms option #318
Conversation
wusize
requested review from
innerlee and
jin-s13
and removed request for
innerlee
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
+ Coverage 83.98% 83.99% +0.01%
==========================================
Files 115 115
Lines 7230 7236 +6
Branches 1141 1141
==========================================
+ Hits 6072 6078 +6
Misses 947 947
Partials 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -361,15 +361,18 @@ def evaluate(self, outputs, res_folder, metric='mAP', **kwargs): | |||
| # rescoring | |||
| n_p['score'] = kpt_score * box_score | |||
|
|
|||
| nms = soft_oks_nms if self.soft_nms else oks_nms | |||
| keep = nms(list(img_kpts), oks_thr, sigmas=self.sigmas) | |||
| if self.use_nms: | |||
There was a problem hiding this comment.
if self.use_nms and len(img_kpts) > 0:
There was a problem hiding this comment.
According to discussion, nms will always return values if input is non-empty
There was a problem hiding this comment.
We might need these lines in case of len(img_kpts)=0.
There was a problem hiding this comment.
see the code posted above
There was a problem hiding this comment.
Em,,, I mean it's very likely that "img_kpts = kpts[image_id]" gets an empty list [ ], in the case of which nms will return an empty list [ ] and "if len(keep) == 0: valid_kpts.append(img_kpts)" would be necessary.
There was a problem hiding this comment.
Okay, so nms does not guarantee that the return be non-empty when img_kpts is non-empty?
There was a problem hiding this comment.
Oh, now I get the point. I erroneously thought that [img_kpts[_keep] for _keep in keep] would raise raise if keep=[] and img_kpts=[], but it won't.
And sure nms does guarantee that. I was talking about the empty case but now it's also not a problem. So if len(keep) == 0: valid_kpts.append(img_kpts) is unnecessary in both cases. I will rm these lines.
* add use_nms option * use default value * rm unnecessary lines * rm unnecessary lines Co-authored-by: jinsheng <jinsheng@sensetime.com>
* add use_nms option * use default value * rm unnecessary lines * rm unnecessary lines Co-authored-by: jinsheng <jinsheng@sensetime.com>
Add use_nms option