Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #50

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Update README.md #50

merged 1 commit into from
Aug 4, 2020

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Aug 4, 2020

fix typos.

@jin-s13 jin-s13 requested a review from innerlee August 4, 2020 02:48
@innerlee
Copy link
Contributor

innerlee commented Aug 4, 2020

the diff shows typo fixes in readme, and nothing in test/data has changed.

@jin-s13
Copy link
Collaborator Author

jin-s13 commented Aug 4, 2020

the diff shows typo fixes in readme, and nothing in test/data has changed.

Yes. Only the typos.

@innerlee
Copy link
Contributor

innerlee commented Aug 4, 2020

not related to this pr, but how about adding links to their corresponding configs on the names, like

image

@innerlee innerlee merged commit d7973fd into master Aug 4, 2020
@innerlee innerlee deleted the jin-s13-patch-1 branch August 4, 2020 03:19
@jin-s13
Copy link
Collaborator Author

jin-s13 commented Aug 4, 2020

not related to this pr, but how about adding links to their corresponding configs on the names, like

image

Let me try.

@innerlee
Copy link
Contributor

innerlee commented Aug 4, 2020

For the links, write the path from the repo root, which starts with a leading slash /. in this way, the docs site would be smart enough to link back to this repo.

image

rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants