support bottom-up demo #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inference_pose_model to inference_top_down_pose_model add video demo for bottom-up models update readme support cpu demo add rotation
Closed
innerlee
commented
Aug 17, 2020
mmpose/models/detectors/bottom_up.py
Outdated
| x_coord, y_coord, kpt_score = int(kpt[0]), int(kpt[1]), kpt[2] | ||
| if kpt_score > kpt_score_thr: | ||
| # cv2.circle(img, (x_coord, y_coord), radius, | ||
| # pose_kpt_color, thickness) |
There was a problem hiding this comment.
so pose_kpt_color is not used?
There was a problem hiding this comment.
Oh, pose_kpt_color is used in line284...
jin-s13
approved these changes
Aug 17, 2020
innerlee
commented
Aug 17, 2020
| result, | ||
| skeleton=None, | ||
| kpt_score_thr=0.3, | ||
| pose_kpt_color=None, |
There was a problem hiding this comment.
since None is not a valid value for pose_kpt_color and pose_limb_color in this function, it is better to either
- do not provide defaults in the signature
- assert that they are not None
- provide default colors when None
There was a problem hiding this comment.
I prefer option 3 btw
There was a problem hiding this comment.
change to "draw kpt&limbs, only if the color is not None".
And add assert to the color.
rollingman1
pushed a commit
to rollingman1/mmpose
that referenced
this pull request
Nov 5, 2021
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
Co-authored-by: jinsheng <jinsheng@sensetime.com>
HAOCHENYE
added a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
* add impl * add test * Fix as comment * Fix as comment * Fix as comment * Fix as comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29 and fix #71