Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Zero-shot Knowledge Transfer via Adversarial Belief Matching #241

Merged
merged 7 commits into from
Aug 24, 2022

Conversation

wilxy
Copy link
Contributor

@wilxy wilxy commented Aug 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add a data-free distillation algorithm named Zero-shot Knowledge Transfer via Adversarial Belief Matching.

Modification

1.Add generaor (zskt_generator) and loss (at_loss) for zskt.
2.Add config, readme, image for zskt.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@wilxy wilxy requested review from pppppM and fpshuang August 23, 2022 07:29
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #241 (dc11b2f) into dev-1.x (ba71abf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           dev-1.x    #241      +/-   ##
==========================================
- Coverage     0.44%   0.44%   -0.01%     
==========================================
  Files          161     163       +2     
  Lines         6506    6545      +39     
  Branches      1064    1068       +4     
==========================================
  Hits            29      29              
- Misses        6472    6511      +39     
  Partials         5       5              
Flag Coverage Δ
unittests 0.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mrazor/models/architectures/generators/__init__.py 0.00% <0.00%> (ø)
.../models/architectures/generators/dafl_generator.py 0.00% <ø> (ø)
.../models/architectures/generators/zskt_generator.py 0.00% <0.00%> (ø)
...or/models/architectures/heads/darts_subnet_head.py 0.00% <0.00%> (ø)
...mrazor/models/distillers/configurable_distiller.py 0.00% <0.00%> (ø)
mmrazor/models/losses/__init__.py 0.00% <0.00%> (ø)
mmrazor/models/losses/at_loss.py 0.00% <0.00%> (ø)
mmrazor/models/losses/kl_divergence.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wilxy wilxy requested a review from sunnyxiaohu August 23, 2022 07:43
volume={32},
year={2019}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Acknowledgement: appreciate Davidgzx's contribution

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


def forward(self,
data: Optional[torch.Tensor] = None,
batch_size: int = 0) -> torch.Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch_size defaulted to 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise it to 1.

Copy link
Contributor

@fpshuang fpshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a-okay to me.

add acknowledgement as comment, plz

loss = (self.at(s_feature) - self.at(t_feature)).pow(2).mean()
return self.loss_weight * loss

def at(self, x: torch.Tensor) -> torch.Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the method name meaningfull and clear, such as at -> calc_attention_matrix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sunnyxiaohu sunnyxiaohu merged commit 876b2ac into open-mmlab:dev-1.x Aug 24, 2022
@wilxy wilxy deleted the df-zskt branch August 24, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants