-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Zero-shot Knowledge Transfer via Adversarial Belief Matching #241
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-1.x #241 +/- ##
==========================================
- Coverage 0.44% 0.44% -0.01%
==========================================
Files 161 163 +2
Lines 6506 6545 +39
Branches 1064 1068 +4
==========================================
Hits 29 29
- Misses 6472 6511 +39
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
volume={32}, | ||
year={2019} | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add Acknowledgement: appreciate Davidgzx's contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
def forward(self, | ||
data: Optional[torch.Tensor] = None, | ||
batch_size: int = 0) -> torch.Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch_size defaulted to 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revise it to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a-okay to me.
add acknowledgement as comment, plz
mmrazor/models/losses/at_loss.py
Outdated
loss = (self.at(s_feature) - self.at(t_feature)).pow(2).mean() | ||
return self.loss_weight * loss | ||
|
||
def at(self, x: torch.Tensor) -> torch.Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make the method name meaningfull and clear, such as at
-> calc_attention_matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add a data-free distillation algorithm named Zero-shot Knowledge Transfer via Adversarial Belief Matching.
Modification
1.Add generaor (zskt_generator) and loss (at_loss) for zskt.
2.Add config, readme, image for zskt.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: