Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enchance] Set a random seed when the user does not set a seed #1039

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

Junjun2016
Copy link
Collaborator

Motivation

Currently, when the seed is not set in the command line, the training process will not do anything with seed. This may cause a potential error in some cases (when different threads have different seeds).

  • When the seed is not set in the args, it will randomly generate a seed and broadcast to all ranks.
  • cfg.seed=seed

Related PR open-mmlab/mmdetection#6354, open-mmlab/mmdetection#6457, open-mmlab/mmdetection#6339

@Junjun2016 Junjun2016 changed the title [Enchance] Set a random seed when the user does not set a seed. [Enchance] Set a random seed when the user does not set a seed Nov 14, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (d665f6b) to head (64cf90e).
Report is 301 commits behind head on master.

Files Patch % Lines
mmseg/apis/train.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
- Coverage   89.55%   89.41%   -0.15%     
==========================================
  Files         119      119              
  Lines        6626     6639      +13     
  Branches     1034     1037       +3     
==========================================
+ Hits         5934     5936       +2     
- Misses        488      499      +11     
  Partials      204      204              
Flag Coverage Δ
unittests 89.41% <26.66%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Junjun2016 Junjun2016 requested a review from xvjiarui November 14, 2021 20:55
@RockeyCoss
Copy link
Contributor

Please merge the master branch into your branch, thank you.

@Junjun2016 Junjun2016 merged commit f0426c9 into open-mmlab:master Nov 26, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* Catch symlink failure on Windows

* Fix typo in setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants