-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix test error when using --show-dir #1091
Conversation
Hi @zergzzlun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 89.57% 89.54% -0.04%
==========================================
Files 120 122 +2
Lines 6717 6932 +215
Branches 1122 1156 +34
==========================================
+ Hits 6017 6207 +190
- Misses 496 519 +23
- Partials 204 206 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @zergzzlun Thanks for your contribution. I just created a PR https://github.com/zergzzlun/mmsegmentation/pull/1 in your repo (since I couldn't push to your repo directly). Could you please have a look on that? |
Hi, @zergzzlun . Please have a look at pr in your forked repo. If you approve it, we would merge this pr as soon as possible. Thanks again for your contribution. |
Move show before test
Hi team. |
Hi, could you have a try on your new commit code with/witout |
Tested it. The new version is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It works perfectly. |
* Fix test error when using --show-dir * Move show before test Co-authored-by: Jiarui XU <xvjiarui0826@gmail.com>
* Create train_dreambooth_inpaint.py train_dreambooth.py adapted to work with the inpaint model, generating random masks during the training * Update train_dreambooth_inpaint.py refactored train_dreambooth_inpaint with black * Update train_dreambooth_inpaint.py * Update train_dreambooth_inpaint.py * Update train_dreambooth_inpaint.py Fix prior preservation * add instructions to readme, fix SD2 compatibility
Hi @zergzlun!First of all, we want to express our gratitude for your significant PR in the MMSegmentation project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Motivation
Fix #1073
Test error mentioned in #1073 is caused by
pre_eval()
changing the segmentation result.Modification
Changed results from
pre_eval()
fromresult
topre_eval_results
.