Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix test error when using --show-dir #1091

Merged
merged 3 commits into from
Dec 6, 2021
Merged

[Fix] Fix test error when using --show-dir #1091

merged 3 commits into from
Dec 6, 2021

Conversation

zergzzlun
Copy link
Contributor

Motivation

Fix #1073
Test error mentioned in #1073 is caused by pre_eval() changing the segmentation result.

Modification

Changed results from pre_eval() from result to pre_eval_results.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2021

CLA assistant check
All committers have signed the CLA.

@Junjun2016
Copy link
Collaborator

Hi @zergzzlun
Thanks for your nice fix.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (91cbe06) to head (61ddc29).
Report is 287 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   89.57%   89.54%   -0.04%     
==========================================
  Files         120      122       +2     
  Lines        6717     6932     +215     
  Branches     1122     1156      +34     
==========================================
+ Hits         6017     6207     +190     
- Misses        496      519      +23     
- Partials      204      206       +2     
Flag Coverage Δ
unittests 89.54% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MengzhangLI
Copy link
Contributor

It works well on my local environemt. Fix the bug.

Before:
image

After:
image

frankfurt_000000_000294_leftImg8bit

@MengzhangLI MengzhangLI added the WIP Work in process label Dec 2, 2021
@xvjiarui
Copy link
Collaborator

xvjiarui commented Dec 3, 2021

Hi @zergzzlun

Thanks for your contribution. I just created a PR https://github.com/zergzzlun/mmsegmentation/pull/1 in your repo (since I couldn't push to your repo directly).

Could you please have a look on that?

@MengzhangLI
Copy link
Contributor

Hi, @zergzzlun .

Please have a look at pr in your forked repo. If you approve it, we would merge this pr as soon as possible.

Thanks again for your contribution.

@zergzzlun
Copy link
Contributor Author

zergzzlun commented Dec 3, 2021

Hi team.
Thanks for your kind words. zergzzlun#1 has been merged.

@MengzhangLI
Copy link
Contributor

Hi team. Thanks for you kind words. zergzzlun#1 has been merged.

Hi, could you have a try on your new commit code with/witout --show-dir command? Thank you.

@zergzzlun
Copy link
Contributor Author

Hi team. Thanks for you kind words. zergzzlun#1 has been merged.

Hi, could you have a try on your new commit code with/witout --show-dir command? Thank you.

Tested it. The new version is fine.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xvjiarui xvjiarui merged commit d3e11cc into open-mmlab:master Dec 6, 2021
@Junjun2016 Junjun2016 removed the WIP Work in process label Dec 6, 2021
@haims-hblab
Copy link

It works perfectly.

@haims-hblab haims-hblab mentioned this pull request Dec 14, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* Fix test error when using --show-dir

* Move show before test

Co-authored-by: Jiarui XU <xvjiarui0826@gmail.com>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* Create train_dreambooth_inpaint.py

train_dreambooth.py adapted to work with the inpaint model, generating random masks during the training

* Update train_dreambooth_inpaint.py

refactored train_dreambooth_inpaint with black

* Update train_dreambooth_inpaint.py

* Update train_dreambooth_inpaint.py

* Update train_dreambooth_inpaint.py

Fix prior preservation

* add instructions to readme, fix SD2 compatibility
@OpenMMLab-Assistant003
Copy link

Hi @zergzlun!First of all, we want to express our gratitude for your significant PR in the MMSegmentation project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @zergzlun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test error
7 participants