Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the bug that mit cannot process init_cfg #1102

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

RockeyCoss
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

[Fix] Fix the bug that mit cannot process init_cfg

Modification

[Fix] Fix the bug that mit cannot process init_cfg

@RockeyCoss RockeyCoss requested a review from Junjun2016 December 5, 2021 23:44
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #1102 (1a3e7e9) into master (f8ed148) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
+ Coverage   89.50%   89.61%   +0.10%     
==========================================
  Files         122      122              
  Lines        6928     6923       -5     
  Branches     1153     1152       -1     
==========================================
+ Hits         6201     6204       +3     
+ Misses        523      516       -7     
+ Partials      204      203       -1     
Flag Coverage Δ
unittests 89.61% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/mit.py 87.68% <100.00%> (+5.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ed148...1a3e7e9. Read the comment docs.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I will fix the init usage in PR #1069.

@Junjun2016
Copy link
Collaborator

Hi @RockeyCoss
Please fix the conflict.

@MengzhangLI MengzhangLI added the Merging PR waited for merging label Dec 8, 2021
@xvjiarui xvjiarui merged commit c23e902 into open-mmlab:master Dec 9, 2021
@MengzhangLI MengzhangLI removed the Merging PR waited for merging label Dec 14, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* [Fix] Fix the bug that mit cannot process init_cfg

* fix error
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* Rename latent

* uP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants