Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove unexist arg in docstring #1106

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

KangBK0120
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Might be trivial but it may be confusing to someone.

Modification

It seems that the loss_type arg in DiceLoss is not used anywhere but it exists in the docstring and docs.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2021

CLA assistant check)
All committers have signed the CLA.

@MengzhangLI
Copy link
Contributor

Hi, thanks for your pr.

The 'loss_type' has been removed in this PR, the related docstring should also be removed.

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1106 (3cd8c6e) into master (2918220) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         122      122           
  Lines        6931     6931           
  Branches     1156     1156           
=======================================
  Hits         6206     6206           
  Misses        519      519           
  Partials      206      206           
Flag Coverage Δ
unittests 89.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/losses/dice_loss.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2918220...3cd8c6e. Read the comment docs.

@Junjun2016 Junjun2016 merged commit ec03773 into open-mmlab:master Dec 6, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants