Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add auto resume #1172

Merged
merged 7 commits into from
Jan 11, 2022
Merged

Conversation

RockeyCoss
Copy link
Contributor

@RockeyCoss RockeyCoss commented Dec 29, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

add auto resume
Related PR: https://github.com/open-mmlab/mmdetection/pull/6727/files

Modification

If --auto-resume is specified when using tools/train.py, The latest checkpoint in the work directory will be automatically loaded.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #1172 (a912e33) into master (7f06e01) will decrease coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.02%     
==========================================
  Files         125      126       +1     
  Lines        7268     7296      +28     
  Branches     1206     1214       +8     
==========================================
+ Hits         6547     6571      +24     
- Misses        518      522       +4     
  Partials      203      203              
Flag Coverage Δ
unittests 90.06% <86.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/train.py 19.71% <20.00%> (-1.18%) ⬇️
mmseg/utils/__init__.py 100.00% <100.00%> (ø)
mmseg/utils/misc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8c93e...a912e33. Read the comment docs.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add related PR to the PR message.

@Junjun2016 Junjun2016 requested a review from MeowZheng December 29, 2021 14:38
RockeyCoss and others added 3 commits January 4, 2022 12:28
Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
@RockeyCoss RockeyCoss requested a review from MeowZheng January 4, 2022 04:40
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to rename mmseg/utils/find_latest_checkpoint.py mmseg/utils/misc.py, as find_latest_checkpoint might be not big enough to be a module.

RockeyCoss and others added 2 commits January 10, 2022 11:41
Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
@RockeyCoss
Copy link
Contributor Author

it would be better to rename mmseg/utils/find_latest_checkpoint.py mmseg/utils/misc.py, as find_latest_checkpoint might be not big enough to be a module.

OK. Could you tell me that what misc stands for? Thanks.

@RockeyCoss RockeyCoss requested a review from MeowZheng January 10, 2022 03:48
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016 Junjun2016 merged commit 78fdf65 into open-mmlab:master Jan 11, 2022
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* [Feature] add auto resume

* Update mmseg/utils/find_latest_checkpoint.py

Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>

* Update mmseg/utils/find_latest_checkpoint.py

Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>

* modify docstring

* Update mmseg/utils/find_latest_checkpoint.py

Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>

* add copyright

Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* Add a reference to the name 'Sampler'

- Facilitate people that are familiar with the name samplers to understand that we call that schedulers
- Better SEO if people are googling for samplers to find our library as well

* Update README.md with a reference to 'Sampler'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants