Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Delete unnecessary lines of STDCHead #1231

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

MengzhangLI
Copy link
Contributor

@MengzhangLI MengzhangLI commented Jan 24, 2022

Motivation

In related Issue: #1230.

It is unnecessary to use F.interpolate in STDCHead because in BaseDecodeHead.losses it already uses resize( ) in

def losses(self, seg_logit, seg_label):
"""Compute segmentation loss."""
loss = dict()
seg_logit = resize(
input=seg_logit,
size=seg_label.shape[2:],
mode='bilinear',
align_corners=self.align_corners)
.

Config names ss mIoU (old) ss mIoU (this PR)
stdc1_512x1024_80k_cityscapes.py 71.52  71.0
stdc1_in1k-pre_512x1024_80k_cityscapes.py 75.10 75.06
stdc2_512x1024_80k_cityscapes.py 73.20 73.62
stdc2_in1k-pre_512x1024_80k_cityscapes.py 77.17  76.9

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1231 (8654fe8) into master (4b905cb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         128      128              
  Lines        7464     7463       -1     
  Branches     1241     1241              
==========================================
- Hits         6736     6735       -1     
  Misses        524      524              
  Partials      204      204              
Flag Coverage Δ
unittests 90.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/stdc_head.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdac9ac...8654fe8. Read the comment docs.

@MengzhangLI MengzhangLI self-assigned this Jan 24, 2022
@MeowZheng MeowZheng merged commit 02d2790 into open-mmlab:master Jan 28, 2022
@MengzhangLI MengzhangLI deleted the fix_stdc_align_corners branch February 1, 2022 03:18
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants