-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Update correct In Collection
in metafile of each configs.
#1239
[Fix] Update correct In Collection
in metafile of each configs.
#1239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 131 131
Lines 7599 7599
Branches 1264 1264
=======================================
Hits 6858 6858
Misses 531 531
Partials 210 210
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Values of In Collection
don't match the collection names
@@ -1,5 +1,5 @@ | |||
Collections: | |||
- Name: erfnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on my limited knowledge, erfnet might be an algorithm not backbone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR currently delete Collections
dict in some backbone readme such as HRNet, Swin Transformer and so on because they may be supported in MMClassification. Other methods which is algorithm rather than backbones all keep Collections
dict but the Collection['Name']
and Models['In Collection']
are the same value.
…en-mmlab#1239) * change md2yml file * update metafile * update twins In Collection automatically * fix twins metafile * fix twins metafile * all metafile use value of Method * update collect name * update collect name * fix some typo * fix FCN D6 * change JPU to FastFCN * fix some typos in DNLNet, NonLocalNet, SETR, Segmenter, STDC, FastSCNN * fix typo in stdc * fix typo in DNLNet and UNet * fix NonLocalNet typo
Motivation
Use correct
In Collection
names of each method, especiallyIn Collection
and backbone ofMetadata
should be different.This pr would be merged after PR #1233 because they all modify
md2yml
file.Related PR:
MMDetection3D: open-mmlab/mmdetection3d#1184.