Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Add exception for PointRend for support CPU-only usage #1271

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

xvjiarui
Copy link
Collaborator

@xvjiarui xvjiarui commented Feb 8, 2022

Motivation

Support CPU-only usage. User may need to run mmseg on CPU-only. But mmcv.ops import will fail on CPU-only installation. Add exception handler to fix that.

Modification

Add an exception for PointRend imports

BC-breaking (Optional)

No

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1271 (5ec0b10) into master (b4314f9) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   90.26%   90.22%   -0.05%     
==========================================
  Files         130      130              
  Lines        7553     7558       +5     
  Branches     1257     1258       +1     
==========================================
+ Hits         6818     6819       +1     
- Misses        528      531       +3     
- Partials      207      208       +1     
Flag Coverage Δ
unittests 90.22% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/point_head.py 93.54% <33.33%> (-3.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4314f9...5ec0b10. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Lint error.

@xvjiarui xvjiarui merged commit 82a8088 into open-mmlab:master Feb 9, 2022
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
…n-mmlab#1271)

* [Improve] Add exception for PointRend for support CPU-only usage

* fixed linting
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants