[Fix] Add Pytorch HardSwish assertion in unit test #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeowZheng
reviewed
Feb 16, 2022
MeowZheng
reviewed
Feb 16, 2022
zhouzaida
approved these changes
Feb 16, 2022
MengzhangLI
force-pushed
the
fix_unittest_HSwish
branch
from
1aa5fa3
to
28f41bc
Compare
MeowZheng
changed the title
MeowZheng
approved these changes
Feb 16, 2022
Codecov Report
@@ Coverage Diff @@
## master #1294 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 130 130
Lines 7560 7560
Branches 1258 1258
=======================================
Hits 6821 6821
Misses 531 531
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zhouzaida
approved these changes
Feb 16, 2022
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
* assert original HardSwish when PyTorch > 1.6 in unit test * assert original HardSwish when PyTorch > 1.6 in unit test * assert original HardSwish when PyTorch > 1.6 in unit test * assert original HardSwish when PyTorch > 1.6 in unit test * assert original HardSwish when PyTorch > 1.6 in unit test * assert original HardSwish when PyTorch > 1.6 in unit test
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
* vq diffusion classifier free sampling * correct * uP Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In latest MMCV==1.4.5, it uses PyTorch official implementation of HardSwish when Pytorch > 1.6.
Related PR: open-mmlab/mmcv#1709.
We would add more flexible assertion in MMSegmentation unit test to pass CI.