[Feature]: Add MAE #1307

YuanLiuuuuuu · 2022-02-21T03:40:28Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
The documentation has been modified accordingly, like docstring or example tutorials.

CLAassistant · 2022-02-21T03:40:33Z

All committers have signed the CLA.

YuanLiuuuuuu · 2022-02-21T03:41:03Z

@MengzhangLI @Junjun2016

Junjun2016 · 2022-04-02T18:00:37Z

Hi @YuanLiuuuuuu
Please resolve the conflicts.

MeowZheng

might solve the conflict first.

YuanLiuuuuuu · 2022-04-10T09:37:59Z

Hi @YuanLiuuuuuu Please resolve the conflicts.

conflicts have been resolved

YuanLiuuuuuu · 2022-04-10T09:38:19Z

might solve the conflict first.

conflicts have been resolved

mmseg/models/backbones/mae.py

configs/_base_/models/upernet_mae.py

configs/_base_/datasets/ade20k_512x512.py

codecov · 2022-04-10T13:40:45Z

Codecov Report

Merging #1307 (8404f4d) into master (69b28e0) will increase coverage by 0.04%.
The diff coverage is 91.91%.

@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
+ Coverage   90.36%   90.40%   +0.04%     
==========================================
  Files         140      141       +1     
  Lines        8344     8443      +99     
  Branches     1400     1423      +23     
==========================================
+ Hits         7540     7633      +93     
- Misses        569      572       +3     
- Partials      235      238       +3

Flag	Coverage Δ
unittests	`90.40% <91.91%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmseg/models/backbones/mae.py	`91.83% <91.83%> (ø)`
mmseg/models/backbones/__init__.py	`100.00% <100.00%> (ø)`
mmseg/models/backbones/beit.py	`93.12% <0.00%> (+0.76%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b28e0...8404f4d. Read the comment docs.

configs/mae/upernet_mae_base_12_512_slide_160k_ade20k_pt2ft.py

mmseg/models/backbones/mae.py

YuanLiuuuuuu · 2022-04-25T12:51:03Z

Please approve workflows to run the following checks.

mmseg/models/backbones/mae.py

configs/mae/README.md

* [Fix]: Fix lint * [WIP]: Add mae seg config * [Feature]: Add MAE seg * [Fix]: Fix mae dataset img scale bug * [Fix]: Fix lint * [Feature]: Change mae config to mae_segmentation's config * [Feature]: Add interpolate pe when loading * [Fix]: Fix pos_embed not used bug * [Fix]: Fix lint * [Fix]: Init rel pos embed with zeros * [Fix]: Fix lint * [Fix]: Change the type name of backbone to MAE * [Fix]: Delete ade20k_512x512.py * [Fix]: Use mmseg provided ade20k.py * [Fix]: Change 1 sample per gpu to 2 samples per gpu * [Fix]: Fix conflict * [Refactor]: Use the TransformerEncoderLayer of BEiT * [Feature]: Add UT * [Fix]: Change the default value of qv bias to False * [Fix]: Initialize relative pos table with zeros * [Fix]: Delete redundant code in mae * [Fix]: Fix lint * [Fix]: Rename qkv_bias to qv_bias * [Fix]: Add docstring to weight_init of MAEAttention * [Refactor]: Delete qv_bias param * [Fix]: Add reference to fix_init_weight * [Fix]: Fix lint * [Fix]: Delete extra crop size * [Refactor]: Rename mae * [Fix]: Set bias to True * [Fix]: Delete redundant params * [Fix]: Fix lint * [Fix]: Fix UT * [Fix]: Add resize abs pos embed * [Fix]: Fix UT * [Refactor]: Use build layer * [Fix]: Add licsense and fix docstring * [Fix]: Fix docstring * [Feature]: Add README metafile * [Fix]: Change 640 to 512 * [Fix]: Fix README * fix readme of MAE Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>

Revert "Update pr docs actions (open-mmlab#1194)" This reverts commit 32b0736.

* [Fix]: Fix lint * [WIP]: Add mae seg config * [Feature]: Add MAE seg * [Fix]: Fix mae dataset img scale bug * [Fix]: Fix lint * [Feature]: Change mae config to mae_segmentation's config * [Feature]: Add interpolate pe when loading * [Fix]: Fix pos_embed not used bug * [Fix]: Fix lint * [Fix]: Init rel pos embed with zeros * [Fix]: Fix lint * [Fix]: Change the type name of backbone to MAE * [Fix]: Delete ade20k_512x512.py * [Fix]: Use mmseg provided ade20k.py * [Fix]: Change 1 sample per gpu to 2 samples per gpu * [Fix]: Fix conflict * [Refactor]: Use the TransformerEncoderLayer of BEiT * [Feature]: Add UT * [Fix]: Change the default value of qv bias to False * [Fix]: Initialize relative pos table with zeros * [Fix]: Delete redundant code in mae * [Fix]: Fix lint * [Fix]: Rename qkv_bias to qv_bias * [Fix]: Add docstring to weight_init of MAEAttention * [Refactor]: Delete qv_bias param * [Fix]: Add reference to fix_init_weight * [Fix]: Fix lint * [Fix]: Delete extra crop size * [Refactor]: Rename mae * [Fix]: Set bias to True * [Fix]: Delete redundant params * [Fix]: Fix lint * [Fix]: Fix UT * [Fix]: Add resize abs pos embed * [Fix]: Fix UT * [Refactor]: Use build layer * [Fix]: Add licsense and fix docstring * [Fix]: Fix docstring * [Feature]: Add README metafile * [Fix]: Change 640 to 512 * [Fix]: Fix README * fix readme of MAE Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>

RockeyCoss requested review from MengzhangLI and MeowZheng February 21, 2022 04:49

YuanLiuuuuuu force-pushed the feature/mae branch from f71eb8d to e59acaf Compare March 28, 2022 03:05

MeowZheng reviewed Apr 9, 2022

View reviewed changes

YuanLiuuuuuu force-pushed the feature/mae branch from e59acaf to 3db4b9e Compare April 10, 2022 09:37

YuanLiuuuuuu requested a review from MeowZheng April 10, 2022 09:37

MeowZheng reviewed Apr 10, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

MeowZheng reviewed Apr 10, 2022

View reviewed changes

configs/_base_/models/upernet_mae.py Outdated Show resolved Hide resolved

MeowZheng reviewed Apr 10, 2022

View reviewed changes

configs/_base_/datasets/ade20k_512x512.py Outdated Show resolved Hide resolved

linfangjian01 reviewed Apr 19, 2022

View reviewed changes

configs/mae/upernet_mae_base_12_512_slide_160k_ade20k_pt2ft.py Outdated Show resolved Hide resolved

linfangjian01 reviewed Apr 19, 2022

View reviewed changes

configs/mae/upernet_mae_base_12_512_slide_160k_ade20k_pt2ft.py Outdated Show resolved Hide resolved

linfangjian01 reviewed Apr 19, 2022

View reviewed changes

configs/mae/upernet_mae_base_12_512_slide_160k_ade20k_pt2ft.py Outdated Show resolved Hide resolved

linfangjian01 reviewed Apr 19, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

YuanLiuuuuuu force-pushed the feature/mae branch from dcc42e1 to e1e2c3c Compare April 24, 2022 08:52

MeowZheng reviewed Apr 25, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

MeowZheng reviewed Apr 25, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

MeowZheng reviewed Apr 25, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

mmseg/models/backbones/mae.py Show resolved Hide resolved

YuanLiuuuuuu requested review from MeowZheng and linfangjian01 April 25, 2022 12:50

YuanLiuuuuuu added 4 commits April 27, 2022 14:01

[Fix]: Fix lint

f6ff181

[WIP]: Add mae seg config

7b50088

[Feature]: Add MAE seg

c62a8a4

[Fix]: Fix mae dataset img scale bug

a7e434e

YuanLiuuuuuu added 10 commits April 27, 2022 14:01

[Fix]: Fix lint

4f51079

[Fix]: Delete extra crop size

e90966f

[Refactor]: Rename mae

bf86fb9

[Fix]: Set bias to True

0cbc4d7

[Fix]: Delete redundant params

28834bf

[Fix]: Fix lint

2b21741

[Fix]: Fix UT

163c801

[Fix]: Add resize abs pos embed

2e16704

[Fix]: Fix UT

f562670

[Refactor]: Use build layer

63632e5

YuanLiuuuuuu force-pushed the feature/mae branch from bab3ab2 to 63632e5 Compare April 27, 2022 06:33

MeowZheng reviewed Apr 27, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

MeowZheng reviewed Apr 27, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

MeowZheng reviewed Apr 27, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

[Fix]: Add licsense and fix docstring

940ecb6

MeowZheng reviewed Apr 27, 2022

View reviewed changes

mmseg/models/backbones/mae.py Outdated Show resolved Hide resolved

YuanLiuuuuuu and others added 5 commits April 27, 2022 17:55

[Fix]: Fix docstring

6c3b620

[Feature]: Add README metafile

e9e8333

[Fix]: Change 640 to 512

9c2c0dd

[Fix]: Fix README

d3a3f68

fix readme of MAE

8404f4d

MengzhangLI reviewed Apr 27, 2022

View reviewed changes

configs/mae/README.md Show resolved Hide resolved

MeowZheng approved these changes Apr 27, 2022

View reviewed changes

MeowZheng merged commit dc3e1b0 into open-mmlab:master Apr 27, 2022

YuanLiuuuuuu deleted the feature/mae branch May 3, 2022 12:38

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023

Revert "Update pr docs actions" (open-mmlab#1307)

327ddc8

Revert "Update pr docs actions (open-mmlab#1194)" This reverts commit 32b0736.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature]: Add MAE #1307

[Feature]: Add MAE #1307

YuanLiuuuuuu commented Feb 21, 2022

CLAassistant commented Feb 21, 2022 •

edited

Loading

YuanLiuuuuuu commented Feb 21, 2022

Junjun2016 commented Apr 2, 2022

MeowZheng left a comment

YuanLiuuuuuu commented Apr 10, 2022

YuanLiuuuuuu commented Apr 10, 2022

codecov bot commented Apr 10, 2022 •

edited

Loading

YuanLiuuuuuu commented Apr 25, 2022

[Feature]: Add MAE #1307

[Feature]: Add MAE #1307

Conversation

YuanLiuuuuuu commented Feb 21, 2022

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

CLAassistant commented Feb 21, 2022 • edited Loading

YuanLiuuuuuu commented Feb 21, 2022

Junjun2016 commented Apr 2, 2022

MeowZheng left a comment

Choose a reason for hiding this comment

YuanLiuuuuuu commented Apr 10, 2022

YuanLiuuuuuu commented Apr 10, 2022

codecov bot commented Apr 10, 2022 • edited Loading

Codecov Report

YuanLiuuuuuu commented Apr 25, 2022

CLAassistant commented Feb 21, 2022 •

edited

Loading

codecov bot commented Apr 10, 2022 •

edited

Loading