Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add min_size arg in Resize to keep the shape after resize bigger than slide window #1318

Merged
merged 15 commits into from
Mar 1, 2022

Conversation

linfangjian01
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

add setr_resize

Modification

add setr_resize

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1318 (ebd33e0) into master (e5cd755) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
+ Coverage   90.24%   90.27%   +0.02%     
==========================================
  Files         131      131              
  Lines        7599     7621      +22     
  Branches     1264     1267       +3     
==========================================
+ Hits         6858     6880      +22     
  Misses        531      531              
  Partials      210      210              
Flag Coverage Δ
unittests 90.27% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/pipelines/transforms.py 98.06% <100.00%> (+0.03%) ⬆️
mmseg/models/decode_heads/dnl_head.py 93.75% <0.00%> (ø)
mmseg/models/decode_heads/fcn_head.py 100.00% <0.00%> (ø)
mmseg/models/decode_heads/psp_head.py 100.00% <0.00%> (ø)
mmseg/models/decode_heads/aspp_head.py 100.00% <0.00%> (ø)
mmseg/models/decode_heads/uper_head.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cd755...ebd33e0. Read the comment docs.

mmseg/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved
mmseg/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add UTs for this new feature

@MeowZheng MeowZheng changed the title [Feature] add setr_resize [Feature] Add min_size arg in Resize aug to keep the shape after resize bigger than input size Feb 28, 2022
@Junjun2016
Copy link
Collaborator

CI failed.

@MeowZheng MeowZheng changed the title [Feature] Add min_size arg in Resize aug to keep the shape after resize bigger than input size [Feature] Add min_size arg in Resize to keep the shape after resize bigger than slide window Mar 1, 2022
@MeowZheng MeowZheng merged commit 2d66179 into open-mmlab:master Mar 1, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
…ze bigger than slide window (open-mmlab#1318)

* [Feature] add setr_resize

* fix a bug

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
@jason102811
Copy link

linfangjian01,您好!您在MMSeg项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。
我们非常期待与您继续合作,OpenMMLab专门成立了贡献者组织MMSIG,为贡献者们提供开源证书、荣誉体系和专享好礼,可通过添加微信:openmmlabwx 联系我们(请备注mmsig+GitHub id),由衷希望您能加入!
Dear linfangjian01,
First of all, we want to express our gratitude for your significant PR in the MMSeg project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord: https://discord.gg/qH9fysxPDW. We sincerely hope you will join us!
Best regards! @linfangjian01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants