Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Provide URLs of STDC, Segmenter and Twins pretrained models #1357

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

MengzhangLI
Copy link
Contributor

Motivation

To replace ./pretrain/xxx.pth in configs of twins, segmenter and stdc with URL of MMSegmentation style pretrained models.

In this way, users of MMSegmentation could directly use these config files to train.

@MengzhangLI MengzhangLI self-assigned this Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1357 (e5277b6) into master (a7c2f68) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1357   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         132      132           
  Lines        7699     7699           
  Branches     1290     1290           
=======================================
  Hits         6954     6954           
  Misses        531      531           
  Partials      214      214           
Flag Coverage Δ
unittests 90.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cc322...e5277b6. Read the comment docs.

@MeowZheng MeowZheng self-requested a review March 9, 2022 02:26
@MeowZheng MeowZheng merged commit 8f33d68 into open-mmlab:master Mar 9, 2022
@MengzhangLI MengzhangLI deleted the backbone_pretrain_url branch March 9, 2022 14:08
mob5566 pushed a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
…-mmlab#1357)

* [Proposal] Support loading from safetensors if file is present.

* Style.

* Fix.

* Adding some test to check loading logic.

+ modify download logic to not download pytorch file if not necessary.

* Fixing the logic.

* Adressing comments.

* factor out into a function.

* Remove dead function.

* Typo.

* Extra fetch only if safetensors is there.

* Apply suggestions from code review

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants