Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add diff seeds to diff ranks and set torch seed in worker_… #1362

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

RockeyCoss
Copy link
Contributor

@RockeyCoss RockeyCoss commented Mar 9, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add diff seeds to diff ranks and set torch seed in worker_init_fn
Related PR:open-mmlab/mmselfsup#228

Modification

Add diff seeds to diff ranks and set torch seed in worker_init_fn

@RockeyCoss RockeyCoss requested a review from MeowZheng March 9, 2022 13:11
@Junjun2016
Copy link
Collaborator

Hi @RockeyCoss
Could add the related PR to PR message instead of the doc in feishu.

@MengzhangLI
Copy link
Contributor

MengzhangLI commented Mar 9, 2022

For example: #1296.

Only need to add related PR of other codebase.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1362 (dee8e1a) into master (66b3790) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.02%     
==========================================
  Files         132      132              
  Lines        7702     7703       +1     
  Branches     1290     1290              
==========================================
  Hits         6957     6957              
- Misses        531      532       +1     
  Partials      214      214              
Flag Coverage Δ
unittests 90.31% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/builder.py 86.74% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b3790...dee8e1a. Read the comment docs.

@MeowZheng MeowZheng merged commit 7dba7a2 into open-mmlab:master Mar 10, 2022
@Junjun2016
Copy link
Collaborator

Could update related docs.
Refer to open-mmlab/mmocr#820 (review).

mob5566 pushed a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants