Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #1375: add demo/image_demo.py support for STARE #1376

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

CCODING04
Copy link
Contributor

Motivation

Add STARE dataset demo/image_demo.py support

Modification

mmseg/core/evaluation/class_names.py

def stare_classes():
    """stare class names for external use."""
    return ['background', 'vessel']

def stare_palette():
    """STARE palette for external use"""
    return [[120, 120, 120], [6, 230, 230]]

# dataset_aliases added (omit)

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@MengzhangLI
Copy link
Contributor

MengzhangLI commented Mar 15, 2022

LGTM except for minor typo.

Please fix the lint error @CCODING04!

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1376 (ce3d954) into master (17b500f) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head ce3d954 differs from pull request most recent head c200bbf. Consider uploading reports for the commit c200bbf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
- Coverage   90.42%   90.39%   -0.03%     
==========================================
  Files         133      133              
  Lines        7902     7906       +4     
  Branches     1318     1318              
==========================================
+ Hits         7145     7147       +2     
- Misses        534      536       +2     
  Partials      223      223              
Flag Coverage Δ
unittests 90.39% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/core/evaluation/class_names.py 88.33% <50.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3aab38...c200bbf. Read the comment docs.

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
@CCODING04
Copy link
Contributor Author

@MengzhangLI
Already taken your advice, thank you 😺

@MeowZheng MeowZheng merged commit 3d0c2eb into open-mmlab:master Mar 15, 2022
mob5566 pushed a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
…en-mmlab#1376)

* Support open-mmlab#1375: add demo/image_demo.py support for STARE

* Update mmseg/core/evaluation/class_names.py

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
…en-mmlab#1376)

* Support open-mmlab#1375: add demo/image_demo.py support for STARE

* Update mmseg/core/evaluation/class_names.py

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* boom boom

* remove duplicate arg

* add use_linear_proj arg

* fix copies

* style

* add fast tests

* use_linear_proj -> use_linear_projection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants