-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid converting label ids twice by label map during evaluation #1417
Conversation
Hi, thanks for your contribution. Plesae fix the lint error! |
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
- Coverage 90.39% 90.30% -0.10%
==========================================
Files 133 139 +6
Lines 7906 8304 +398
Branches 1318 1395 +77
==========================================
+ Hits 7147 7499 +352
- Misses 536 567 +31
- Partials 223 238 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Failed due to
I saw a similar error here, pre-commit/pre-commit#747, but not sure how to fix it |
Its ok. Try more times |
The new commit is added by |
Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
Not sure about the codecov/patch and codecov/project fails, need to merge master? |
…-mmlab#1417) * Avoid converting label ids twice by label map during evaluation * Update mmseg/datasets/custom.py Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> * lint Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> Co-authored-by: MeowZheng <meowzheng@outlook.com>
…-mmlab#1417) * Avoid converting label ids twice by label map during evaluation * Update mmseg/datasets/custom.py Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> * lint Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> Co-authored-by: MeowZheng <meowzheng@outlook.com>
Hi @panfeng-hover!First of all, we want to express our gratitude for your significant PR in the MMSegmentation project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
seg_map
orgt_seg_maps
are already converted by thelabel_map
duringself.get_gt_seg_map_by_idx
orself.get_gt_seg_maps
, pass theself.label_map
tointersect_and_union
oreval_metrics
will do the conversion again.#1415