Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Bisenetv2 config for new dataset #1425

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

JJLimmm
Copy link

@JJLimmm JJLimmm commented Mar 28, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

New project that i am diving into, since AV is the future and testing out a semantic segmentation model to detect water puddles on the road while driving.

Modification

Added in a Custom dataset class called waterpuddlesDataset() with 2 classes; background and waterpuddles.

  1. Added in waterpuddles.py into configs/base/dataset/, the new dataset is following the ChaseDB1 format. Users can convert the dataset from the original public Puddle-1000 dataset and use the ChaseDB1.py under convert_datasets/ to get the required format aligned with ChaseDB1.
  2. Added custom dataset class into mmseg/datasets/ directory called waterpuddles.py
  3. Updated class_names.py in mmseg/core/evaluation/ directory to include the waterpuddles dataset attributes.

BC-breaking (Optional)

Backward-Compatible

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution, but I strongly recommend that you might split this PR into 2 PRs, one is to add the 'warterpuddles' dataset and its cfg file, and the other is for adding new training cfg for bisenetv2.

BTW, please sign CLA

@MengzhangLI
Copy link
Contributor

MengzhangLI commented Mar 28, 2022

Hi, @JJLimmm Thanks so much for your nice PR.

It is better to support this feature by two steps:

First, support water puddle dataset. Please refer to support Vaihingen dataset:#1171.

Second, add BiSeNetV2 for this dataset for a new benchmark, please refer to add FastFCN on ADE20K dataset. #972.

In my point of view, this PR would better just support waterpuddle dataset. Because I think many parts of your config files need to be modified to satisfy merging master branch.

But its OK. Feel free to contact us if you meet any problems.

Best,

'../_base_/datasets/waterpuddles.py', # dataset settings
'../_base_/schedules/schedule_40k.py', # scheduler settings
'../_base_/default_runtime.py' # other runtime settings
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many comment paragraphs. Just keep L4-L9.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1425 (017bb45) into master (30864ea) will decrease coverage by 0.11%.
The diff coverage is 15.38%.

❗ Current head 017bb45 differs from pull request most recent head 69560f6. Consider uploading reports for the commit 69560f6 to get more accurate results

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   90.22%   90.10%   -0.12%     
==========================================
  Files         136      137       +1     
  Lines        7946     7956      +10     
  Branches     1323     1324       +1     
==========================================
  Hits         7169     7169              
- Misses        552      562      +10     
  Partials      225      225              
Flag Coverage Δ
unittests 90.10% <15.38%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/waterpuddles.py 0.00% <0.00%> (ø)
mmseg/core/evaluation/class_names.py 88.33% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a6c39...69560f6. Read the comment docs.

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
@OpenMMLab-Assistant003
Copy link

Hi @JJLimmm!We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @JJLimmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants