-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Bisenetv2 config for new dataset #1425
base: master
Are you sure you want to change the base?
Conversation
Custom_config for waterpuddles dataset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution, but I strongly recommend that you might split this PR into 2 PRs, one is to add the 'warterpuddles' dataset and its cfg file, and the other is for adding new training cfg for bisenetv2.
BTW, please sign CLA
Hi, @JJLimmm Thanks so much for your nice PR. It is better to support this feature by two steps: First, support water puddle dataset. Please refer to support Vaihingen dataset:#1171. Second, add BiSeNetV2 for this dataset for a new benchmark, please refer to add FastFCN on ADE20K dataset. #972. In my point of view, this PR would better just support waterpuddle dataset. Because I think many parts of your config files need to be modified to satisfy merging master branch. But its OK. Feel free to contact us if you meet any problems. Best, |
'../_base_/datasets/waterpuddles.py', # dataset settings | ||
'../_base_/schedules/schedule_40k.py', # scheduler settings | ||
'../_base_/default_runtime.py' # other runtime settings | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many comment paragraphs. Just keep L4-L9.
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
- Coverage 90.22% 90.10% -0.12%
==========================================
Files 136 137 +1
Lines 7946 7956 +10
Branches 1323 1324 +1
==========================================
Hits 7169 7169
- Misses 552 562 +10
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fixed typos
Hi @JJLimmm!We are grateful for your efforts in helping improve this open-source project during your personal time. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
New project that i am diving into, since AV is the future and testing out a semantic segmentation model to detect water puddles on the road while driving.
Modification
Added in a Custom dataset class called waterpuddlesDataset() with 2 classes; background and waterpuddles.
BC-breaking (Optional)
Backward-Compatible
Checklist