Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Input previous results for the last cascade_decode_head #1450

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix # #1353

Modification

  • Input prev_outputs to forward_test for the latter cascade_decode_head.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1450 (da8f6e0) into master (ecd2dc4) will decrease coverage by 0.10%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
- Coverage   90.34%   90.24%   -0.11%     
==========================================
  Files         139      139              
  Lines        8300     8310      +10     
  Branches     1393     1397       +4     
==========================================
  Hits         7499     7499              
- Misses        564      572       +8     
- Partials      237      239       +2     
Flag Coverage Δ
unittests 90.24% <33.33%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/segmentors/cascade_encoder_decoder.py 94.59% <33.33%> (-5.41%) ⬇️
mmseg/apis/train.py 19.51% <0.00%> (-1.83%) ⬇️
mmseg/core/evaluation/metrics.py 93.61% <0.00%> (-1.07%) ⬇️
mmseg/datasets/custom.py 94.73% <0.00%> (ø)
mmseg/datasets/pipelines/loading.py 98.55% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcc0b6...da8f6e0. Read the comment docs.

prev_outputs = self.decode_head[i - 1].forward_test(
x, img_metas, self.test_cfg)
if i == 1:
prev_outputs = self.decode_head[i - 1].forward_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prev_outputs = self.decode_head[i - 1].forward_test(
prev_outputs = self.decode_head[0].forward_test(

@MeowZheng MeowZheng changed the title [Fix] Input previous results for the latter cascade_decode_head [Fix] Input previous results for the last cascade_decode_head Apr 13, 2022
@MeowZheng MeowZheng merged commit 23ae1eb into open-mmlab:master Apr 13, 2022
@MeowZheng MeowZheng deleted the cascade-encoder-decoder branch April 13, 2022 13:16
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
…mlab#1450)

* [Fix] Input previous results for the latter cascade_decode_head

* minors
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants