-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Support single channel pred
for Binary Cross Entropy Loss
#1454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
- Coverage 90.31% 90.28% -0.04%
==========================================
Files 139 139
Lines 8303 8313 +10
Branches 1395 1398 +3
==========================================
+ Hits 7499 7505 +6
- Misses 567 570 +3
- Partials 237 238 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refine pr tittle and pr msg first ref #1438
pred
for Binary Cross Entropy Loss
pred
for Binary Cross Entropy Losspred
for Binary Cross Entropy Loss
…en-mmlab#1454) * [Fix] Fix the bug that binary cross entropy loss doesn't support single channel input * imcrease coverage * modify implementation * increase coverage * add assert * modify implementation * enshollow condition judge * fix
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix the bug that binary cross entropy loss doesn't support single channel input.
Related Issue: #1430
Modification
pred
is one, instead of expanding the lebel to one-hot format,binary_cross_entropy_loss
only unsqueeze thelabel
to match the shape of thepred
.