Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] inconsistent dtype of seg_label in stdc decode #1463

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix #1462

Modification

  • revise seg_label.float to seg_label.to(self.laplacian_kernel) in mmseg/models/decode_heads/stdc_head.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #1463 (4660f80) into master (3432ea9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1463   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         139      139           
  Lines        8303     8304    +1     
  Branches     1395     1395           
=======================================
+ Hits         7499     7500    +1     
  Misses        567      567           
  Partials      237      237           
Flag Coverage Δ
unittests 90.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/stdc_head.py 100.00% <100.00%> (ø)
mmseg/datasets/pipelines/loading.py 98.55% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd32f4...4660f80. Read the comment docs.

@MeowZheng MeowZheng changed the title [Fix] inconsistent dtype ofseg_label in stdc decode [Fix] inconsistent dtype of seg_label in stdc decode Apr 9, 2022
@MeowZheng MeowZheng merged commit 4841933 into open-mmlab:master Apr 10, 2022
@MeowZheng MeowZheng deleted the fix-stdc-dtype branch April 10, 2022 06:18
mob5566 pushed a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants