-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix the bug in binary_cross_entropy #1527
Conversation
Fix the bug in binary_cross_entropy 'label.max() <= 1' should mask out ignore_index, since the ignore_index often set as 255.
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=======================================
Coverage 90.40% 90.40%
=======================================
Files 141 141
Lines 8443 8443
Branches 1423 1423
=======================================
Hits 7633 7633
Misses 572 572
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
As the ignore_index often set as 255, so the binary class label check should mask out ignore_index. Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
As the ignore_index often set as 255, so the binary class label check should mask out ignore_index.
LGTM, but the CI failed. |
I have fix ci in #1532 |
* [Fix] Fix the bug in binary_cross_entropy Fix the bug in binary_cross_entropy 'label.max() <= 1' should mask out ignore_index, since the ignore_index often set as 255. * [Fix] Fix the bug in binary_cross_entropy, add comments As the ignore_index often set as 255, so the binary class label check should mask out ignore_index. Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> * [Fix] Fix the bug in binary_cross_entropy As the ignore_index often set as 255, so the binary class label check should mask out ignore_index. Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> Co-authored-by: MeowZheng <meowzheng@outlook.com>
dawn-bin,您好!您在MMSeg项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。 |
…1527) * refactor init_model and unit test * add topdown inference and minor modification to data pipelines * add topdown image demo * change bbox format from xywh to xyxy * resolve comments
Motivation
Fix the bug in binary_cross_entropy
' label.max() <= 1' should mask out ignore_index, since the ignore_index often set as 255.
Related Issuse #1525
Modification
Add a mask.