Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom palette #157

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Support custom palette #157

merged 2 commits into from
Sep 30, 2020

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Sep 25, 2020

CustomDataset currently supports setting classes via config file, covering two use cases: using your own dataset and using a subset of existing dataset. However because of how it's currently handled, the palette only covers the subset case.

This P.R. includes the option to set palette via configuration files and automatically creates one with random colors when no palette is given.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #157 into master will increase coverage by 0.25%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   83.02%   83.28%   +0.25%     
==========================================
  Files          85       83       -2     
  Lines        3982     3924      -58     
  Branches      627      619       -8     
==========================================
- Hits         3306     3268      -38     
+ Misses        542      521      -21     
- Partials      134      135       +1     
Flag Coverage Δ
#unittests 83.28% <85.71%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/inference.py 21.81% <0.00%> (ø)
mmseg/datasets/custom.py 85.88% <75.00%> (-0.99%) ⬇️
mmseg/models/utils/inverted_residual.py 92.00% <85.71%> (ø)
mmseg/core/utils/__init__.py 100.00% <100.00%> (ø)
mmseg/models/backbones/fast_scnn.py 98.09% <100.00%> (ø)
mmseg/models/backbones/mobilenet_v2.py 72.94% <100.00%> (-3.92%) ⬇️
mmseg/models/decode_heads/sep_aspp_head.py 100.00% <100.00%> (ø)
mmseg/models/decode_heads/sep_fcn_head.py 100.00% <100.00%> (ø)
mmseg/models/utils/__init__.py 100.00% <100.00%> (ø)
mmseg/ops/__init__.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8bc79...aa77200. Read the comment docs.

@hellock
Copy link
Member

hellock commented Sep 29, 2020

ping @xvjiarui

Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
@xvjiarui xvjiarui merged commit 118fd9d into open-mmlab:master Sep 30, 2020
@daavoo daavoo deleted the custom-palette branch September 30, 2020 10:08
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* Fix split

* Update tests/test_data/test_dataset.py

Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>

Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* Add the function of Procrutes Alignment used in 3D joints error evaluation and corresponding test codes.

* Fix the input shape of function compute_similarity_transform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants