Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Replace markdownlint with mdformat for avoiding installing ruby #1591

Merged
merged 3 commits into from
May 20, 2022

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Replace markdownlint with mdformat to avoid installing ruby
related pr open-mmlab/mmcv#1936

Modification

*.md

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1591 (1209a91) into master (9c8658a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1591   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         141      141           
  Lines        8443     8443           
  Branches     1423     1423           
=======================================
  Hits         7633     7633           
  Misses        572      572           
  Partials      238      238           
Flag Coverage Δ
unittests 90.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8658a...1209a91. Read the comment docs.

@MeowZheng MeowZheng changed the title Mdformat [Docs] Replace markdownlint with mdformat for avoiding installing ruby May 17, 2022
@MeowZheng MeowZheng merged commit 104429b into open-mmlab:master May 20, 2022
@MeowZheng MeowZheng deleted the mdformat branch May 20, 2022 10:29
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
open-mmlab#1591)

* [Docs] Replace markdownlint with mdformat for avoiding installing ruby

* [Docs] Replace markdownlint with mdformat for avoiding installing ruby

* lint
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* fix upcast in slice attention

* fix dtype

* add test

* fix test
huajiangjiangLi added a commit to pytorchuser/HDB-Seg that referenced this pull request Apr 12, 2023
open-mmlab#1591)

* [Docs] Replace markdownlint with mdformat for avoiding installing ruby

* [Docs] Replace markdownlint with mdformat for avoiding installing ruby

* lint
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
…ab#1591)

* fix bugs of browsing transformed img

* fix unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants