Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundancies in pytorch2onnx #160

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Remove redundancies in pytorch2onnx #160

merged 2 commits into from
Sep 30, 2020

Conversation

yl-1993
Copy link
Contributor

@yl-1993 yl-1993 commented Sep 26, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 26, 2020 •
edited
Loading

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          83       83           
  Lines        3937     3937           
  Branches      619      619           
=======================================
  Hits         3283     3283           
  Misses        520      520           
  Partials      134      134
Flag Coverage Δ
#unittests 83.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95079b...669eb3e. Read the comment docs.

@xvjiarui
Copy link
Collaborator

Hi @yl-1993
These lines are needed when exporting OCRNet.

@yl-1993
Copy link
Contributor Author

yl-1993 commented Sep 28, 2020

@xvjiarui Thanks. I spotted them when adapting it to mmcls and thought they are redundant. Good to know that they are necessary in some cases. Yet, Line 189-193 may be redundant as num_classes is not used below?

@xvjiarui
Copy link
Collaborator

Hi @yl-1993
You are right. Could you please sign CLA? Then I could merge this PR.

@xvjiarui xvjiarui merged commit f705071 into open-mmlab:master Sep 30, 2020
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
@yl-1993
Remove redundancies in pytorch2onnx (open-mmlab#160)
93a2456 
* rm redundancies

* re-add some packages
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
@anton-l
Add an alternative Karras et al. stochastic scheduler for VE models (o…
dd10da7 
…pen-mmlab#160)

* karras + VE, not flexible yet

* Fix inputs incompatibility with the original unet

* Roll back sigma scaling

* Apply suggestions from code review

* Old comment

* Fix doc
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
@zengwang430521
Add pipelines for human mesh estimation task. Add test codes and test…
cb200ba 
… data. (open-mmlab#160)
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
ONNX exporting support. (open-mmlab#160)
b77de1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvjiarui xvjiarui xvjiarui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yl-1993 @CLAassistant @xvjiarui