Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few spelling errors #1656

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Fixed a few spelling errors #1656

merged 6 commits into from
Jun 14, 2022

Conversation

rotorliu
Copy link

@rotorliu rotorliu commented Jun 9, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2022

CLA assistant check
All committers have signed the CLA.

@MeowZheng
Copy link
Collaborator

Thanks for your contribution, please sign CLA first

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1656 (a001ab7) into master (43b4efb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1656   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         142      142           
  Lines        8478     8478           
  Branches     1429     1429           
=======================================
  Hits         7650     7650           
  Misses        588      588           
  Partials      240      240           
Flag Coverage Δ
unittests 90.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/stdc_head.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b4efb...a001ab7. Read the comment docs.

@MengzhangLI
Copy link
Contributor

Hi, thanks for your nice PR.

Could you please fix the lint error thus we could merge your PR?

Best,

@rotorliu
Copy link
Author

Hi, thanks for your nice PR.

Could you please fix the lint error thus we could merge your PR?

Best,

OK, It's done.

@MengzhangLI
Copy link
Contributor

Hi, thanks for your nice PR.
Could you please fix the lint error thus we could merge your PR?
Best,

OK, It's done.

Still not work.

image

Perhaps you should use pre-commit and try again. Thx!

@MengzhangLI
Copy link
Contributor

image

Still has lint error, it is caused by your wrong pre-commit usage. In correct usage it would raise error above.

The reason is simple, L75-76 should be aligned, like:

        boundary_targets_pyramid = F.conv2d(boundary_targets_pyramids,
                                            self.fusion_kernel)

Rather than:
image

@MengzhangLI
Copy link
Contributor

Sorry to bother you fixing this error. Thanks in advance! @rotorliu

@MeowZheng MeowZheng merged commit f3c72c6 into open-mmlab:master Jun 14, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
* 修复拼写错误

* Fix lint error

* Fix lint error

* Fix lint error
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants