Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect resolution string in config name #1660

Closed
wants to merge 3 commits into from

Conversation

SBCV
Copy link
Contributor

@SBCV SBCV commented Jun 10, 2022

Rename

configs/segmenter/segmenter_vit-l_mask_8x1_512x512_160k_ade20k.py

to

configs/segmenter/segmenter_vit-l_mask_8x1_640x640_160k_ade20k.py,

since it expects a resolution of 640x640.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1660 (8938403) into master (43b4efb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1660   +/-   ##
=======================================
  Coverage   90.23%   90.24%           
=======================================
  Files         142      142           
  Lines        8478     8486    +8     
  Branches     1429     1432    +3     
=======================================
+ Hits         7650     7658    +8     
  Misses        588      588           
  Partials      240      240           
Flag Coverage Δ
unittests 90.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/pipelines/test_time_aug.py 96.55% <0.00%> (+0.25%) ⬆️
mmseg/models/segmentors/encoder_decoder.py 88.66% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b4efb...8938403. Read the comment docs.

@linfangjian01
Copy link
Contributor

Thank you for your contribution,please fix lint.

@SBCV
Copy link
Contributor Author

SBCV commented Jun 10, 2022

How? All I did was renaming the file. This looks to me like a bug in the linter, no?

@xiexinch
Copy link
Collaborator

How? All I did was renaming the file. This looks to me like a bug in the linter, no?

Hi @SBCV
Here is a tutorial about installing pre-commit https://github.com/open-mmlab/mmsegmentation/blob/master/.github/CONTRIBUTING.md

@SBCV
Copy link
Contributor Author

SBCV commented Jun 15, 2022

Hey, sorry for the late reply - was on vacation and had no access to my desktop pc.
Thank you for pointing out the tutorial and adapting the changes for the linter.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

configs/segmenter/segmenter.yml Show resolved Hide resolved
@MeowZheng
Copy link
Collaborator

We fixed the problem about segmenter in #1695, and close this pr.

@MeowZheng MeowZheng closed this Jun 24, 2022
@SBCV SBCV deleted the fix_config_name branch July 23, 2022 20:31
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants