Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix mmseg.api.inference inference_segmentor #1849

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

jinwonkim93
Copy link

@jinwonkim93 jinwonkim93 commented Aug 1, 2022

Motivation

This PR aims to solve #1643.
Fix inference_segmentor not working with multiple images path or images. List[str/ndarray]

Modification

  • process images if instance is list
  • change variable img to imgs

Motivation
Fix inference_segmentor not working with multiple images path or images. List[str/ndarray]

Modification
- process images if instance is list
@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022

CLA assistant check
All committers have signed the CLA.

@jinwonkim93 jinwonkim93 marked this pull request as draft August 1, 2022 06:38
@jinwonkim93 jinwonkim93 marked this pull request as ready for review August 1, 2022 06:40
@jinwonkim93
Copy link
Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

jinwonkim93 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jinwonkim93 jinwonkim93 closed this Aug 1, 2022
@jinwonkim93 jinwonkim93 deleted the fix_segmentor_inference branch August 1, 2022 06:42
@jinwonkim93 jinwonkim93 restored the fix_segmentor_inference branch August 1, 2022 06:42
@jinwonkim93 jinwonkim93 reopened this Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Base: 89.04% // Head: 89.08% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (82182c4) compared to base (13d4c39).
Patch coverage: 95.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
+ Coverage   89.04%   89.08%   +0.03%     
==========================================
  Files         144      145       +1     
  Lines        8636     8695      +59     
  Branches     1458     1464       +6     
==========================================
+ Hits         7690     7746      +56     
- Misses        706      707       +1     
- Partials      240      242       +2     
Flag Coverage Δ
unittests 89.08% <95.38%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/losses/tversky_loss.py 94.44% <94.44%> (ø)
mmseg/apis/inference.py 64.06% <100.00%> (+2.39%) ⬆️
mmseg/models/decode_heads/decode_head.py 92.63% <100.00%> (ø)
mmseg/models/losses/__init__.py 100.00% <100.00%> (ø)
mmseg/version.py 58.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng
Copy link
Collaborator

Many thanks for your contribution, please sign CLA first.

@jinwonkim93
Copy link
Author

Many thanks for your contribution, please sign CLA first.

yes, i did it.

@jinwonkim93
Copy link
Author

@MeowZheng @MengzhangLI Anything you like to comment?

mmseg/apis/inference.py Outdated Show resolved Hide resolved
@jinwonkim93 jinwonkim93 marked this pull request as draft August 28, 2022 02:08
@jinwonkim93 jinwonkim93 marked this pull request as ready for review August 31, 2022 07:30
@jinwonkim93
Copy link
Author

@MengzhangLI Is there something i could do more?

Copy link
Contributor

@nijkah nijkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeowZheng MeowZheng merged commit ecd1ecb into open-mmlab:master Sep 13, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
@jason102811
Copy link

jinwonkim93,您好!您在MMSeg项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。
我们非常期待与您继续合作,OpenMMLab专门成立了贡献者组织MMSIG,为贡献者们提供开源证书、荣誉体系和专享好礼,可通过添加微信:openmmlabwx 联系我们(请备注mmsig+GitHub id),由衷希望您能加入!
Dear jinwonkim93,
First of all, we want to express our gratitude for your significant PR in the MMSeg project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlab_wx, or join in our discord: https://discord.gg/qH9fysxPDW. We sincerely hope you will join us!
Best regards! @jinwonkim93

@jinwonkim93
Copy link
Author

jinwonkim93,您好!您在MMSeg项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。 我们非常期待与您继续合作,OpenMMLab专门成立了贡献者组织MMSIG,为贡献者们提供开源证书、荣誉体系和专享好礼,可通过添加微信:openmmlabwx 联系我们(请备注mmsig+GitHub id),由衷希望您能加入! Dear jinwonkim93, First of all, we want to express our gratitude for your significant PR in the MMSeg project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlab_wx, or join in our discord: https://discord.gg/qH9fysxPDW. We sincerely hope you will join us! Best regards! @jinwonkim93

Thank you for invitation but discord is invalid.

@jason102811
Copy link

please try this new link: https://discord.com/invite/raweFPmdzG

wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants