[Doc] Update add module doc #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeowZheng
reviewed
Sep 15, 2022
Comment on lines
192
to
203
| def train_step(self, | ||
| data: Union[dict, tuple, list], | ||
| optim_wrapper: OptimWrapper) -> Dict[str, torch.Tensor]: | ||
| pass | ||
|
|
||
| def val_step(self, | ||
| data: Union[tuple, dict, list]) -> list: | ||
| pass | ||
|
|
||
| def test_step(self, | ||
| data: Union[tuple, dict, list]) -> list: | ||
| pass |
There was a problem hiding this comment.
BaseModel in MMEngine implements xx_step, and mmseg didn't rewrite them.
I suggest that we should tell users what they should inherit from or rewrite, if they would like to add a segmentor
MeowZheng
reviewed
Sep 16, 2022
MeowZheng
reviewed
Sep 16, 2022
Comment on lines
213
to
215
| def aug_test(self, batch_inputs, batch_img_metas): | ||
| """Placeholder for augmentation test.""" | ||
| pass |
There was a problem hiding this comment.
aug_test isn't supported in openmmlab2.0, please remove it
MeowZheng
reviewed
Sep 16, 2022
| type='MySegmentor' | ||
| ... | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
I think it would be better to add how add a new data preprocessor in mmseg
xiexinch
force-pushed
the
update_add_model_doc
branch
from
7adfb8d to
fd09554
Compare
MeowZheng
approved these changes
Sep 29, 2022
MeowZheng
pushed a commit
to MeowZheng/mmsegmentation
that referenced
this pull request
Nov 1, 2022
* develop segmentor and remove custom optim * update segmentor example * add data preprocessor * refine intro
wjkim81
pushed a commit
to wjkim81/mmsegmentation
that referenced
this pull request
Dec 3, 2023
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
* develop segmentor and remove custom optim * update segmentor example * add data preprocessor * refine intro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As title.
Modification