Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]Resume do not specify ckpt #2074

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Sep 15, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

resume is only used to specify whether launch resume training from the latest checkpoint and load-from is used to load specific checkpoints.

resume in CLI has the same function of resume in Runner. https://github.com/open-mmlab/mmengine/blob/ca0364bbc3a6ac9132f5d499de190f7e733383ca/mmengine/runner/runner.py#L151-L154

Modification

  1. Add action of resume.
  2. Remove the load ckpt from resume.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 83.10% // Head: 83.10% // No change to project coverage 👍

Coverage data is based on head (e8626e5) compared to base (fffb9e2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2074   +/-   ##
========================================
  Coverage    83.10%   83.10%           
========================================
  Files          138      138           
  Lines         7779     7779           
  Branches      1246     1246           
========================================
  Hits          6465     6465           
  Misses        1130     1130           
  Partials       184      184           
Flag Coverage Δ
unittests 83.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 3388cfd into open-mmlab:dev-1.x Sep 15, 2022
@MeowZheng MeowZheng deleted the resume-opt branch September 15, 2022 07:13
MeowZheng added a commit to MeowZheng/mmsegmentation that referenced this pull request Nov 1, 2022
* [Refactor]Resume do not specify ckpt

* add default false value
@MeowZheng MeowZheng added the 1.x Related issue of 1.x version label Nov 1, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
* [Refactor]Resume do not specify ckpt

* add default false value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Related issue of 1.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants