Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]Add out_file in add_datasample to directly save image #2090

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Modification

  1. mmseg/apis/inference.py
  2. mmseg/visualization/local_visualizer.py

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 83.10% // Head: 83.13% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9fab2a1) compared to base (230246f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2090      +/-   ##
===========================================
+ Coverage    83.10%   83.13%   +0.02%     
===========================================
  Files          138      138              
  Lines         7779     7780       +1     
  Branches      1246     1246              
===========================================
+ Hits          6465     6468       +3     
+ Misses        1130     1128       -2     
  Partials       184      184              
Flag Coverage Δ
unittests 83.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/inference.py 0.00% <ø> (ø)
mmseg/visualization/local_visualizer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng changed the title [Enhancement]Add out_file in add_datasample to directly save image' [Enhancement]Add out_file in add_datasample to directly save image Sep 20, 2022
@MengzhangLI MengzhangLI self-requested a review September 20, 2022 07:16
@MeowZheng MeowZheng merged commit 2a18328 into open-mmlab:dev-1.x Sep 20, 2022
@MeowZheng MeowZheng deleted the outfile-vis branch September 20, 2022 07:23
MeowZheng added a commit to MeowZheng/mmsegmentation that referenced this pull request Nov 1, 2022
…pen-mmlab#2090)

* [Enhancement]Add `out_file` in add_datasample to for save vis image directly

* comments

* ut
@MeowZheng MeowZheng added the 1.x Related issue of 1.x version label Nov 1, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
open-mmlab#2090)

scheduling_ddpm: fix variance in the case of learned_range type.

In the case of learned_range variance type, there are missing logs
and exponent comparing to the theory (see "Improved Denoising Diffusion
Probabilistic Models" section 3.1 equation 15:
https://arxiv.org/pdf/2102.09672.pdf).
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
…pen-mmlab#2090)

* [Enhancement]Add `out_file` in add_datasample to for save vis image directly

* comments

* ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Related issue of 1.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants