Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Use syncbn in mobilenet_v2 #2207

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

xiexinch
Copy link
Collaborator

Motivation

ref #2198

Modification

Add norm_cfg to the backbone cfg

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 89.09% // Head: 89.09% // No change to project coverage 👍

Coverage data is based on head (6f2c364) compared to base (356215b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2207   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         145      145           
  Lines        8721     8721           
  Branches     1472     1472           
=======================================
  Hits         7770     7770           
  Misses        708      708           
  Partials      243      243           
Flag Coverage Δ
unittests 89.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 04afdb3 into open-mmlab:master Oct 18, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Related to open-mmlab#2124 
The current implementation is throwing a shape mismatch error. Which makes sense, as this line is obviously missing, comparing to XFormersCrossAttnProcessor and LoRACrossAttnProcessor.

I don't have formal tests, but I compared `LoRACrossAttnProcessor` and `LoRAXFormersCrossAttnProcessor` ad-hoc, and they produce the same results with this fix.
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants