add dice evaluation metric #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 84.35% 84.58% +0.22%
==========================================
Files 90 90
Lines 4340 4385 +45
Branches 687 701 +14
==========================================
+ Hits 3661 3709 +48
+ Misses 537 536 -1
+ Partials 142 140 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xvjiarui
reviewed
Nov 6, 2020
xvjiarui
reviewed
Nov 6, 2020
xvjiarui
reviewed
Nov 6, 2020
xvjiarui
reviewed
Nov 19, 2020
mmseg/datasets/custom.py
Outdated
|
|
||
| class_table_data.append( | ||
| [class_names[i]] + | ||
| [round(m[i] * 100, 2) for m in ret_metrics[2:]] + |
There was a problem hiding this comment.
I suggest using np.round once for all.
xvjiarui
reviewed
Nov 19, 2020
mmseg/datasets/custom.py
Outdated
| class_table_data.append( | ||
| [class_names[i]] + | ||
| [round(m[i] * 100, 2) for m in ret_metrics[2:]] + | ||
| [round(ret_metrics[1][i] * 100, 2)]) |
There was a problem hiding this comment.
Why is this order? Will [1:] work?
xvjiarui
reviewed
Nov 19, 2020
xvjiarui
reviewed
Nov 23, 2020
mmseg/datasets/custom.py
Outdated
| @@ -315,57 +315,58 @@ def evaluate(self, results, metric='mIoU', logger=None, **kwargs): | |||
|
|
|||
| Args: | |||
| results (list): Testing results of the dataset. | |||
| metric (str | list[str]): Metrics to be evaluated. | |||
| metric (str | list[str]): Metrics to be evaluated. 'mIoU' and | |||
| 'mDice' are support ONLY. | |||
There was a problem hiding this comment.
Suggested change
| 'mDice' are support ONLY. | |
| 'mDice' are supported. |
xvjiarui
reviewed
Nov 23, 2020
mmseg/datasets/custom.py
Outdated
Comment on lines
353
to
362
| [np.round(m[i] * 100, 2) for m in ret_metrics[2:]] + | ||
| [np.round(ret_metrics[1][i] * 100, 2)]) | ||
| summary_table_data = [['Scope'] + | ||
| ['m' + head | ||
| for head in class_table_data[0][1:]] + ['aAcc']] | ||
| summary_table_data.append( | ||
| ['global'] + | ||
| [np.round(np.nanmean(m) * 100, 2) for m in ret_metrics[2:]] + | ||
| [np.round(np.nanmean(ret_metrics[1]) * 100, 2)] + | ||
| [np.round(np.nanmean(ret_metrics[0]) * 100, 2)]) |
There was a problem hiding this comment.
We may use np.round once for all.
xvjiarui
approved these changes
Nov 24, 2020
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
* add dice evaluation metric * add dice evaluation metric * add dice evaluation metric * support 2 metrics * support 2 metrics * support 2 metrics * support 2 metrics * fix docstring * use np.round once for all
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
* Update README for 0.2.3 release: * Apply suggestions from code review Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
sibozhang
pushed a commit
to sibozhang/mmsegmentation
that referenced
this pull request
Mar 22, 2024
* linting * polish * polish * polish * polish * polish * polish * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dice evaluation metric